add some additional tests to cover code paths and potential errors.

Author: phlptp

tests/OptionGroupTest.cpp

@@ -119,6 +119,30 @@ TEST_F(TApp, BasicOptionGroupMax) {
     EXPECT_NE(exactloc, std::string::npos);
 }
 
+TEST_F(TApp, BasicOptionGroupMax1) {
+    auto ogroup = app.add_option_group("clusters");
+    int res;
+    ogroup->add_option("--test1", res);
+    ogroup->add_option("--test2", res);
+    ogroup->add_option("--test3", res);
+    int val2;
+    app.add_option("--option", val2);
+    ogroup->require_option(-1);
+    args = {"--test1", "5"};
+    run();
+    EXPECT_EQ(res, 5);
+
+    args = {"--option", "9"};
+    EXPECT_NO_THROW(run());
+
+    args = {"--test1", "5", "--test2", "4"};
+    EXPECT_THROW(run(), CLI::RequiredError);
+
+    std::string help = ogroup->help();
+    auto exactloc = help.find("[At most 1");
+    EXPECT_NE(exactloc, std::string::npos);
+}
+
 TEST_F(TApp, BasicOptionGroupMin) {
     auto ogroup = app.add_option_group("clusters");
     int res;
@@ -140,6 +164,51 @@ TEST_F(TApp, BasicOptionGroupMin) {
     EXPECT_NE(exactloc, std::string::npos);
 }
 
+TEST_F(TApp, BasicOptionGroupExact2) {
+    auto ogroup = app.add_option_group("clusters");
+    int res;
+    ogroup->add_option("--test1", res);
+    ogroup->add_option("--test2", res);
+    ogroup->add_option("--test3", res);
+    int val2;
+    app.add_option("--option", val2);
+    ogroup->require_option(2);
+
+    args = {"--option", "9"};
+    EXPECT_THROW(run(), CLI::RequiredError);
+
+    args = {"--test1", "5", "--test2", "4", "--test3=5"};
+    EXPECT_THROW(run(), CLI::RequiredError);
+
+    args = {"--test1", "5", "--test3=5"};
+    EXPECT_NO_THROW(run());
+
+    std::string help = ogroup->help();
+    auto exactloc = help.find("[Exactly 2");
+    EXPECT_NE(exactloc, std::string::npos);
+}
+
+TEST_F(TApp, BasicOptionGroupMin2) {
+    auto ogroup = app.add_option_group("clusters");
+    int res;
+    ogroup->add_option("--test1", res);
+    ogroup->add_option("--test2", res);
+    ogroup->add_option("--test3", res);
+    int val2;
+    app.add_option("--option", val2);
+    ogroup->require_option(2, 0);
+
+    args = {"--option", "9"};
+    EXPECT_THROW(run(), CLI::RequiredError);
+
+    args = {"--test1", "5", "--test2", "4", "--test3=5"};
+    EXPECT_NO_THROW(run());
+
+    std::string help = ogroup->help();
+    auto exactloc = help.find("[At least 2");
+    EXPECT_NE(exactloc, std::string::npos);
+}
+
 TEST_F(TApp, BasicOptionGroupMinMoved) {
 
     int res;
@@ -223,6 +292,23 @@ TEST_F(TApp, BasicOptionGroupAddFailures) {
     EXPECT_THROW(ogroup->add_option(opt3), CLI::OptionAlreadyAdded);
 }
 
+TEST_F(TApp, BasicOptionGroupScrewedUpMove) {
+
+    int res;
+    auto opt1 = app.add_option("--test1", res);
+    auto opt2 = app.add_option("--test2", res);
+    int val2;
+    app.add_option("--option", val2);
+
+    auto ogroup = app.add_option_group("clusters");
+    ogroup->require_option();
+    auto ogroup2 = ogroup->add_option_group("clusters2");
+    EXPECT_THROW(ogroup2->add_options(opt1, opt2), CLI::OptionNotFound);
+
+    CLI::Option_group EmptyGroup("description", "new group", nullptr);
+
+    EXPECT_THROW(EmptyGroup.add_option(opt2), CLI::OptionNotFound);
+}
 /*
 struct SubcommandProgram : public TApp {