Skip to content

Commit 906ab0a

Browse files
committed
Fix unqualified attribute issue (fixes #237)
1 parent 12397f0 commit 906ab0a

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/rules/unqualified-attributes.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ CSSLint.addRule({
2929
if (part.type == parser.SELECTOR_PART_TYPE){
3030
for (k=0; k < part.modifiers.length; k++){
3131
modifier = part.modifiers[k];
32-
if (modifier.type == "attribute" && (!modifier.elementName || modifier.elementName == "*")){
33-
reporter.report(rule.desc, modifier.line, modifier.col, rule);
32+
if (modifier.type == "attribute" && (!part.elementName || part.elementName == "*")){
33+
reporter.report(rule.desc, part.line, part.col, rule);
3434
}
3535
}
3636
}

tests/rules/unqualified-attributes.js

+6
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,14 @@
2424
"Using an unqualified attribute selector in the middle should not result in a warning": function(){
2525
var result = CSSLint.verify("[type=text] .foo { font-size: 10px; } ", {"unqualified-attributes": 1 });
2626
Assert.areEqual(0, result.messages.length);
27+
},
28+
29+
"Using a qualified attribute selector should not result in a warning": function(){
30+
var result = CSSLint.verify("input[type=text] { font-size: 10px; } ", {"unqualified-attributes": 1 });
31+
Assert.areEqual(0, result.messages.length);
2732
}
2833

34+
2935
}));
3036

3137
})();

0 commit comments

Comments
 (0)