Rollup merge of rust-lang#60169 - varkor:tidy-unnecessary-ignore-newline, r=kennytm

Warn when ignore-tidy-linelength is present, but no lines are too long

It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.

Author: Centril

src/ci/docker/dist-various-1/install-x86_64-redox.sh

@@ -1,5 +1,4 @@
 #!/usr/bin/env bash
-# ignore-tidy-linelength
 
 set -ex
 

src/ci/docker/dist-various-2/build-fuchsia-toolchain.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
 
-# ignore-tidy-linelength
-
 set -ex
 source shared.sh
 

src/test/codegen-units/item-collection/cross-crate-closures.rs

@@ -3,7 +3,6 @@
 // ignoring this test until MIR codegen has taken over completely
 // ignore-test
 
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/cross-crate-generic-functions.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/cross-crate-trait-method.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/function-as-argument.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/generic-functions.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/generic-impl.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/impl-in-non-instantiated-generic.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/items-within-generic-items.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/non-generic-functions.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/overloaded-operators.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/static-init.rs

@@ -1,5 +1,4 @@
 // compile-flags:-Zprint-mono-items=eager
-// ignore-tidy-linelength
 
 #![feature(start)]
 

src/test/codegen-units/item-collection/statics-and-consts.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/trait-implementations.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/trait-method-as-argument.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/trait-method-default-impl.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/unreferenced-const-fn.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=lazy
 
 #![deny(dead_code)]

src/test/codegen-units/item-collection/unreferenced-inline-function.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=lazy
 
 // N.B., we do not expect *any* monomorphization to be generated here.

src/test/codegen-units/item-collection/unsizing.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 // compile-flags:-Zinline-in-all-cgus
 

src/test/codegen-units/item-collection/unused-traits-and-generics.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags:-Zprint-mono-items=eager
 
 #![crate_type="lib"]

src/test/codegen-units/partitioning/statics.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // We specify -Z incremental here because we want to test the partitioning for
 // incremental compilation
 // compile-flags:-Zprint-mono-items=lazy -Zincremental=tmp/partitioning-tests/statics

src/test/codegen/adjustments.rs

@@ -1,5 +1,4 @@
 // compile-flags: -C no-prepopulate-passes
-// ignore-tidy-linelength
 
 #![crate_type = "lib"]
 

src/test/codegen/enum-debug-niche.rs

@@ -2,7 +2,6 @@
 // before 7.0, then backported to the Rust LLVM fork.  It tests that
 // optimized enum debug info accurately reflects the enum layout.
 
-// ignore-tidy-linelength
 // ignore-windows
 // min-system-llvm-version 8.0
 

src/test/codegen/enum-debug-tagged.rs

@@ -2,7 +2,6 @@
 // before 7.0, then backported to the Rust LLVM fork.  It tests that
 // debug info for tagged (ordinary) enums is properly emitted.
 
-// ignore-tidy-linelength
 // ignore-windows
 // min-system-llvm-version 8.0
 

src/test/codegen/generic-debug.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // ignore-windows
 
 // compile-flags: -g -C no-prepopulate-passes

src/test/codegen/mainsubprogram.rs

@@ -1,7 +1,6 @@
 // This test depends on a patch that was committed to upstream LLVM
 // before 4.0, formerly backported to the Rust LLVM fork.
 
-// ignore-tidy-linelength
 // ignore-windows
 // ignore-macos
 

src/test/codegen/mainsubprogramstart.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // ignore-windows
 // ignore-macos
 

src/test/codegen/noreturn-uninhabited.rs

@@ -1,5 +1,4 @@
 // compile-flags: -g -C no-prepopulate-passes
-// ignore-tidy-linelength
 
 #![crate_type = "lib"]
 

src/test/codegen/noreturnflag.rs

@@ -1,5 +1,4 @@
 // compile-flags: -g -C no-prepopulate-passes
-// ignore-tidy-linelength
 
 #![crate_type = "lib"]
 

src/test/codegen/panic-abort-windows.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // This test is for *-windows-msvc only.
 // ignore-android
 // ignore-bitrig

src/test/codegen/refs.rs

@@ -1,5 +1,4 @@
 // compile-flags: -C no-prepopulate-passes
-// ignore-tidy-linelength
 
 #![crate_type = "lib"]
 

src/test/codegen/remap_path_prefix/xcrate-generic.rs

@@ -1,5 +1,4 @@
 // ignore-windows
-// ignore-tidy-linelength
 // compile-flags: -g -C metadata=foo -C no-prepopulate-passes
 // aux-build:xcrate-generic.rs
 

src/test/codegen/vtabletype.rs

@@ -1,7 +1,6 @@
 // This test depends on a patch that was committed to upstream LLVM
 // after 5.0, then backported to the Rust LLVM fork.
 
-// ignore-tidy-linelength
 // ignore-windows
 // ignore-macos
 

src/test/debuginfo/enum-thinlto.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // Require LLVM with DW_TAG_variant_part and a gdb that can read it.
 // min-system-llvm-version: 8.0
 // min-gdb-version: 8.2

src/test/debuginfo/generic-enum-with-different-disr-sizes.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // ignore-lldb: FIXME(#27089)
 // min-lldb-version: 310
 

src/test/debuginfo/recursive-struct.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // ignore-lldb
 
 // Require LLVM with DW_TAG_variant_part and a gdb that can read it.

src/test/debuginfo/unique-enum.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // Require LLVM with DW_TAG_variant_part and a gdb and lldb that can
 // read it.
 // min-system-llvm-version: 8.0

src/test/incremental/remapped_paths_cc/auxiliary/extern_crate.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 //[rpass1] compile-flags: -g
 //[rpass2] compile-flags: -g
 //[rpass3] compile-flags: -g --remap-path-prefix={{src-base}}=/the/src

src/test/mir-opt/basic_assignment.rs

@@ -5,8 +5,6 @@
 // so subtle breakage in them can leave a quite hard-to-find trail of
 // destruction.
 
-// ignore-tidy-linelength
-
 fn main() {
     let nodrop_x = false;
     let nodrop_y;

src/test/mir-opt/nll/named-lifetimes-basic.rs

@@ -5,7 +5,6 @@
 
 // compile-flags:-Zborrowck=mir -Zverbose
 //                              ^^^^^^^^^ force compiler to dump more region information
-// ignore-tidy-linelength
 
 #![allow(warnings)]
 

src/test/mir-opt/storage_ranges.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 fn main() {
     let a = 0;
     {

src/test/run-pass/issues/issue-16278.rs

@@ -3,8 +3,8 @@
 
 // this file has some special \r\n endings (use xxd to see them)
 
-fn main() {assert_eq!(b"", b"\
+fn main() {assert_eq!(b"", b"\
                                    ");
-assert_eq!(b"\n", b"
+assert_eq!(b"\n", b"
 ");
 }

src/test/rustdoc-ui/intra-link-span-ice-55723.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-end-whitespace
-
 #![deny(intra_doc_link_resolution_failure)]
 
 // An error in calculating spans while reporting intra-doc link resolution errors caused rustdoc to

src/test/rustdoc-ui/intra-link-span-ice-55723.stderr

@@ -1,11 +1,11 @@
 error: `[i]` cannot be resolved, ignoring it...
-  --> $DIR/intra-link-span-ice-55723.rs:11:10
+  --> $DIR/intra-link-span-ice-55723.rs:9:10
    |
 LL | /// （arr[i]）
    |           ^ cannot be resolved, ignoring
    |
 note: lint level defined here
-  --> $DIR/intra-link-span-ice-55723.rs:3:9
+  --> $DIR/intra-link-span-ice-55723.rs:1:9
    |
 LL | #![deny(intra_doc_link_resolution_failure)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/test/rustdoc/empty-mod-private.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags: --document-private-items
 
 // @has 'empty_mod_private/index.html' '//a[@href="foo/index.html"]' 'foo'

src/test/rustdoc/extern-html-root-url.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // compile-flags:-Z unstable-options --extern-html-root-url core=https://example.com/core/0.1.0
 
 // @has extern_html_root_url/index.html

src/test/rustdoc/method-list.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 #![crate_name = "foo"]
 
 // @has foo/struct.Foo.html

src/test/rustdoc/pub-method.rs

@@ -1,4 +1,3 @@
-// ignore-tidy-linelength
 // compile-flags: --document-private-items
 
 #![crate_name = "foo"]

src/test/ui/borrowck/two-phase-activation-sharing-interference.nll_target.stderr

@@ -1,5 +1,5 @@
 error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
-  --> $DIR/two-phase-activation-sharing-interference.rs:32:15
+  --> $DIR/two-phase-activation-sharing-interference.rs:30:15
    |
 LL |     let y = &mut x;
    |             ------ mutable borrow occurs here
@@ -10,7 +10,7 @@ LL |     *y += 1;
    |     ------- mutable borrow later used here
 
 error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
-  --> $DIR/two-phase-activation-sharing-interference.rs:40:13
+  --> $DIR/two-phase-activation-sharing-interference.rs:38:13
    |
 LL |     let y = &mut x;
    |             ------ mutable borrow occurs here
@@ -21,7 +21,7 @@ LL |     *y += 1;
    |     ------- mutable borrow later used here
 
 error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
-  --> $DIR/two-phase-activation-sharing-interference.rs:51:13
+  --> $DIR/two-phase-activation-sharing-interference.rs:49:13
    |
 LL |     let y = &mut x;
    |             ------ mutable borrow occurs here
@@ -32,7 +32,7 @@ LL |     *y += 1;
    |     ------- mutable borrow later used here
 
 error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
-  --> $DIR/two-phase-activation-sharing-interference.rs:62:14
+  --> $DIR/two-phase-activation-sharing-interference.rs:60:14
    |
 LL |     let y = &mut x;
    |             ------ mutable borrow occurs here

src/test/ui/borrowck/two-phase-activation-sharing-interference.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // revisions: nll_target
 
 // The following revisions are disabled due to missing support from two-phase beyond autorefs

src/test/ui/consts/const-array-oob.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 #![feature(const_indexing)]
 
 const FOO: [usize; 3] = [1, 2, 3];

src/test/ui/consts/const-array-oob.stderr

@@ -1,5 +1,5 @@
 error[E0080]: evaluation of constant value failed
-  --> $DIR/const-array-oob.rs:8:19
+  --> $DIR/const-array-oob.rs:6:19
    |
 LL | const BLUB: [u32; FOO[4]] = [5, 6];
    |                   ^^^^^^ index out of bounds: the len is 3 but the index is 4

src/test/ui/deprecation/deprecation-in-future.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // run-pass
 
 #![deny(deprecated_in_future)]

src/test/ui/deprecation/deprecation-in-future.stderr

@@ -1,5 +1,5 @@
 warning: use of deprecated item 'deprecated_future': text
-  --> $DIR/deprecation-in-future.rs:11:5
+  --> $DIR/deprecation-in-future.rs:9:5
    |
 LL |     deprecated_future(); // ok; deprecated_in_future only applies to rustc_deprecated
    |     ^^^^^^^^^^^^^^^^^

src/test/ui/derives/deriving-meta-unknown-trait.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 #[derive(Eqr)]
 //~^ ERROR cannot find derive macro `Eqr` in this scope
 struct Foo;

src/test/ui/derives/deriving-meta-unknown-trait.stderr

@@ -1,5 +1,5 @@
 error: cannot find derive macro `Eqr` in this scope
-  --> $DIR/deriving-meta-unknown-trait.rs:3:10
+  --> $DIR/deriving-meta-unknown-trait.rs:1:10
    |
 LL | #[derive(Eqr)]
    |          ^^^ help: try: `Eq`

src/test/ui/discrim/discrim-overflow-2.rs

@@ -1,5 +1,3 @@
-// ignore-tidy-linelength
-
 // Issue 23030: Detect overflowing discriminant
 //
 // Check that we detect the overflow even if enum is not used.