validateReceivedMessage: check duplicate message first (#223)

Author: twoeths

ts/index.ts

@@ -932,13 +932,6 @@ export default class Gossipsub extends EventEmitter {
   async validateReceivedMessage(propagationSource: PeerId, rpcMsg: RPC.IMessage): Promise<ReceivedMessageResult> {
     this.metrics?.onMsgRecvPreValidation(rpcMsg.topic)
 
-    // Perform basic validation on message and convert to RawGossipsubMessage for fastMsgIdFn()
-    const validationResult = await validateToRawMessage(this.globalSignaturePolicy, rpcMsg)
-
-    if (!validationResult.valid) {
-      return { code: MessageStatus.invalid, reason: RejectReason.Error, error: validationResult.error }
-    }
-
     // Fast message ID stuff
     const fastMsgIdStr = this.fastMsgIdFn?.(rpcMsg)
     const msgIdCached = fastMsgIdStr && this.fastMsgIdCache?.get(fastMsgIdStr)
@@ -948,6 +941,13 @@ export default class Gossipsub extends EventEmitter {
       return { code: MessageStatus.duplicate, msgId: msgIdCached }
     }
 
+    // Perform basic validation on message and convert to RawGossipsubMessage for fastMsgIdFn()
+    const validationResult = await validateToRawMessage(this.globalSignaturePolicy, rpcMsg)
+
+    if (!validationResult.valid) {
+      return { code: MessageStatus.invalid, reason: RejectReason.Error, error: validationResult.error }
+    }
+
     // Try and perform the data transform to the message. If it fails, consider it invalid.
     let data: Uint8Array
     try {