fix: remove metrics from component (#17)

Since muxers are factories there's no point tracking stream metrics for each instance as they trample over each other, so remove the use of tracked maps in this module.

This was added to mplex by mistake and copied here, but it's since been removed from mplex so this change brings yamux in line.

Author: achingbrain

package.json

@@ -171,10 +171,8 @@
   },
   "dependencies": {
     "@libp2p/interface-connection": "^3.0.1",
-    "@libp2p/interface-metrics": "^3.0.0",
     "@libp2p/interface-stream-muxer": "^3.0.0",
     "@libp2p/logger": "^2.0.1",
-    "@libp2p/tracked-map": "^2.0.2",
     "abortable-iterator": "^4.0.2",
     "any-signal": "^3.0.1",
     "err-code": "^3.0.1",

src/index.ts

@@ -1,8 +1,8 @@
 import type { StreamMuxerFactory } from '@libp2p/interface-stream-muxer'
 import { Yamux } from './muxer.js'
-import type { YamuxMuxerInit, YamuxComponents } from './muxer.js'
+import type { YamuxMuxerInit } from './muxer.js'
 export { GoAwayCode } from './frame.js'
 
-export function yamux (init: YamuxMuxerInit = {}): (components?: YamuxComponents) => StreamMuxerFactory {
-  return (components: YamuxComponents = {}) => new Yamux(components, init)
+export function yamux (init: YamuxMuxerInit = {}): () => StreamMuxerFactory {
+  return () => new Yamux(init)
 }

src/muxer.ts

@@ -3,7 +3,6 @@ import type { StreamMuxer, StreamMuxerFactory, StreamMuxerInit } from '@libp2p/i
 import { abortableSource } from 'abortable-iterator'
 import { pipe } from 'it-pipe'
 import type { Sink, Source } from 'it-stream-types'
-import { trackedMap } from '@libp2p/tracked-map'
 import { pushable, Pushable } from 'it-pushable'
 import errcode from 'err-code'
 import anySignal from 'any-signal'
@@ -15,29 +14,22 @@ import { Config, defaultConfig, verifyConfig } from './config.js'
 import { Decoder } from './decode.js'
 import type { Logger } from '@libp2p/logger'
 import type { Uint8ArrayList } from 'uint8arraylist'
-import type { Metrics } from '@libp2p/interface-metrics'
 
 const YAMUX_PROTOCOL_ID = '/yamux/1.0.0'
 
 export interface YamuxMuxerInit extends StreamMuxerInit, Partial<Config> {
 }
 
-export interface YamuxComponents {
-  metrics?: Metrics
-}
-
 export class Yamux implements StreamMuxerFactory {
   protocol = YAMUX_PROTOCOL_ID
-  private readonly components: YamuxComponents
   private readonly _init: YamuxMuxerInit
 
-  constructor (components: YamuxComponents, init: YamuxMuxerInit = {}) {
-    this.components = components
+  constructor (init: YamuxMuxerInit = {}) {
     this._init = init
   }
 
   createStreamMuxer (init?: YamuxMuxerInit): YamuxMuxer {
-    return new YamuxMuxer(this.components, {
+    return new YamuxMuxer({
       ...this._init,
       ...init
     })
@@ -82,7 +74,7 @@ export class YamuxMuxer implements StreamMuxer {
   private readonly onIncomingStream?: (stream: Stream) => void
   private readonly onStreamEnd?: (stream: Stream) => void
 
-  constructor (components: YamuxComponents, init: YamuxMuxerInit) {
+  constructor (init: YamuxMuxerInit) {
     this._init = init
     this.client = init.direction === 'outbound'
     this.config = { ...defaultConfig, ...init }
@@ -94,7 +86,7 @@ export class YamuxMuxer implements StreamMuxer {
     this.onIncomingStream = init.onIncomingStream
     this.onStreamEnd = init.onStreamEnd
 
-    this._streams = trackedMap({ metrics: components.metrics, component: 'yamux', metric: 'streams' })
+    this._streams = new Map()
 
     this.source = pushable({
       onEnd: (err?: Error): void => {

test/util.ts

@@ -33,7 +33,7 @@ export class TestYamux extends Yamux {
 }
 
 export function testYamuxMuxer (name: string, client: boolean, conf: YamuxMuxerInit = {}) {
-  return new YamuxMuxer({}, {
+  return new YamuxMuxer({
     ...testConf,
     ...conf,
     direction: client ? 'outbound' : 'inbound',