Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

🎨 Update the webpack to build per package #5140

Merged
merged 24 commits into from
Jun 23, 2022
Merged

Conversation

nazarhussain
Copy link
Contributor

Description

Update the webpack configurations to build per package.

Fixes #5068

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nazarhussain nazarhussain self-assigned this Jun 16, 2022
@nazarhussain nazarhussain added the 4.x 4.0 related label Jun 16, 2022
@nazarhussain nazarhussain mentioned this pull request Jun 16, 2022
16 tasks
Base automatically changed from junaid/4xwebpackbuildconfig to 4.x June 16, 2022 13:19
Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix lint test

@nazarhussain nazarhussain requested a review from avkos June 22, 2022 15:35
@nazarhussain nazarhussain merged commit 2992fe9 into 4.x Jun 23, 2022
@nazarhussain nazarhussain deleted the nh/webpack-refactor branch June 23, 2022 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants