You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// this is an unassigned importimport'../cc-button/cc-button.js';
Although all other imports are correctly sorted, unassigned imports are not checked and there are some disparities between components: in one component, unassigned imports are coded before all imports, in an another, they are coded after.
@roberttran-cc I didn't know about this issue but this is very clear and well documented, gg! 👏
If it's ok with you I'll close it because the import order is now handled by prettier thanks to @Galimede!
Also, the eslint-plugin-simple-import-sort is still in our deps even though we don't use it ( 🙈 ) but I've removed it from the project within the eslint flat config migration PR 👍
(feel free to reopen if you think I've missed something)
Little reminder:
Although all other imports are correctly sorted, unassigned imports are not checked and there are some disparities between components: in one component, unassigned imports are coded before all imports, in an another, they are coded after.
We use the
eslint-plugin-import
plugin which clearly state:And it seems this behavior won't be considered anytime soon by this plugin.
Maybe consider testing the
sort-imports
rule built ineslint
, especially themembersyntaxsortorder
option.Note: the
eslint-plugin-simple-import-sort
dependency in ourpackage.json
is not used, we can remove it as part of this issue.The text was updated successfully, but these errors were encountered: