Skip to content

Commit 0e51eba

Browse files
committed
fix: conditins for show and hide queryElements
1 parent 715f353 commit 0e51eba

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

Diff for: src/index.js

+19-19
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ function initElement(el) {
2828
el.removeEventListener('change', selectShowHideEle);
2929

3030
el.addEventListener("change", selectShowHideEle);
31-
}
32-
else {
31+
} else {
3332
el.removeEventListener('change', selectShowHideEle);
3433
el.removeEventListener("click", clickShowHideEle);
3534

@@ -82,30 +81,31 @@ function clickShowHideEle(e) {
8281
el.removeAttribute('hidden');
8382
}
8483
}
85-
}
86-
else {
84+
} else {
8785

8886
let updated_els = [];
8987

90-
for (let el of queryElements({ element: document, selector: show, type: 'selector' })) {
91-
if (el.hasAttribute('hidden')) {
92-
el.removeAttribute('hidden');
93-
updated_els.push(el);
88+
if (show)
89+
for (let el of queryElements({ element: document, selector: show, type: 'selector' })) {
90+
if (el.hasAttribute('hidden')) {
91+
el.removeAttribute('hidden');
92+
updated_els.push(el);
93+
}
9494
}
95-
}
9695

97-
for (let el of queryElements({ element: document, selector: hide, type: 'selector' })) {
98-
let existEqual = false;
99-
for (let uel of updated_els) {
100-
if (el.isEqualNode(uel)) {
101-
existEqual = true;
102-
break;
96+
if (hide)
97+
for (let el of queryElements({ element: document, selector: hide, type: 'selector' })) {
98+
let existEqual = false;
99+
for (let uel of updated_els) {
100+
if (el.isEqualNode(uel)) {
101+
existEqual = true;
102+
break;
103+
}
103104
}
104-
}
105105

106-
if (!existEqual)
107-
el.setAttribute('hidden', '')
108-
}
106+
if (!existEqual)
107+
el.setAttribute('hidden', '')
108+
}
109109
}
110110

111111
document.dispatchEvent(new CustomEvent('showHide', {

0 commit comments

Comments
 (0)