Skip to content

Add support for PHI3 model #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victorratts13 opened this issue May 3, 2024 · 3 comments
Open

Add support for PHI3 model #29

victorratts13 opened this issue May 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@victorratts13
Copy link

Type of feature request

🌟New Model

Feature description

The phi3 model is important for certain application scenarios, and its addition would significantly increase the flexibility and usefulness of the library for users. We appreciate your consideration of this request and are available to provide any additional information if needed.

Motivation

Currently, when attempting to use the phi3 model for a task, the following runtime error occurs:

The model type `phi3` is not supported for this task. Please check for typos or refer to the documentation for the list of supported model types.

This indicates that the phi3 model is not supported by the library for the given task. However, in response to user requests and the need to utilize the phi3 model, we would like to request the addition of support for this model in the library.

Your contribution

Proposal:

  • Add support for the phi3 model in functionalities related to the library's pipeline.
  • Update the documentation to include information on using the phi3 model.
  • Ensure that the phi3 model is properly integrated into the existing workflow of the library.
@victorratts13 victorratts13 added the enhancement New feature or request label May 3, 2024
@CodeWithKyrian
Copy link
Owner

Thanks for your continued interest @victorratts13 . As I mentioned in #26, TransformersPHP doesn't support models larger than 2GB for now. OnnxRuntime uses Protobuf buffers to store the models, and they have a 2GB file limit. To make it work, models above that limit have to be split into multiple files, and the current state of the library does not account for downloading and loading multiple files

Rest assured, I have this feature request on top of my mind. Phi 3 is a very fantastic model and gives very impressive results. I'll bump it to the top of the list and work on it as soon as the next release is published (which should be very soon).

@victorratts13
Copy link
Author

Thanks for answering. I'm working on a project responsible for using huggingface AI models with PHP/Laravel. Your library is the most promising I found. If you allow me, I would like to contribute.

@CodeWithKyrian
Copy link
Owner

Yeah sure. I'm very much open to contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants