Implement new PHP features up to 8.0 #119
Conversation
|
What's the idea of these changes? |
Stricter typing I imagine, I'll review it. |
src/Codeception/Module/Yii2.php
Outdated
| 'cookie' => $_COOKIE, | ||
| 'session' => $_SESSION, |
There was a problem hiding this comment.
Are we sure these global variables are set?
There was a problem hiding this comment.
if I go for:
'cookie' => $_COOKIE ?? [],
I get this warning:
phpstan: Variable $_COOKIE on left side of ?? always exists and is not nullable
In the case of $_SESSION I don't get this error, it appears that there are cases in which it may be undefined.
so I guess it should look like:
'cookie' => $_COOKIE,
'session' => $_SESSION ?? [],shouldn't it?
There was a problem hiding this comment.
I think it's a bug in phpstan. I'd just ignore the phpstan message tbh.
TavoNiievez
changed the title
src/Codeception/Module/Yii2.php
Outdated
| 'cookie' => $_COOKIE, | ||
| 'session' => $_SESSION, |
There was a problem hiding this comment.
| 'cookie' => $_COOKIE, | |
| 'session' => $_SESSION, | |
| 'cookie' => $_COOKIE ?? [], | |
| 'session' => $_SESSION ?? [], |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I am not a regular user of Yii, please review critically.