Skip to content

Wrong documentation for amOnPage() #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mytskine opened this issue Jan 24, 2023 · 1 comment
Closed

Wrong documentation for amOnPage() #81

mytskine opened this issue Jan 24, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@mytskine
Copy link

The amOnPage() method used to accept both a path (e.g. /that/3) and a route (e.g. ["/that/view", "id" => 3]). This feature was removed, and the present method is not backward compatible. In fact, one can't use a full route anymore, except by splitting it into amOnRoute() (so upgrading an old test suite is painful). The problem is that the phpdoc was not updated:

     * @param string|array $page the URI or route in array format
     */
    public function amOnPage(string $page): void
@samdark samdark added the documentation Improvements or additions to documentation label Jan 24, 2023
@samdark
Copy link
Member

samdark commented Jun 16, 2023

Fixed by #86

@samdark samdark closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants