Skip to content

Commit 3ebc036

Browse files
committed
Use newest coverage(off) implementation
rust-lang/rust#126721
1 parent 421c979 commit 3ebc036

File tree

3 files changed

+61
-80
lines changed

3 files changed

+61
-80
lines changed

src/diffline.rs

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -40,23 +40,17 @@ pub fn init(diff: DiffChoice) {
4040

4141
#[cfg_attr(coverage_nightly, coverage(off))]
4242
pub fn show(old: &str, new: &str) {
43-
show_difflines(
44-
old,
45-
new,
46-
*DIFF_CHOICE.get().unwrap(),
47-
#[cfg_attr(coverage_nightly, coverage(off))]
48-
|res| match res {
49-
diff::Result::Left(l) => {
50-
diff!(del "{}", l);
51-
}
52-
diff::Result::Both(l, _) => {
53-
diff!("{}", l);
54-
}
55-
diff::Result::Right(r) => {
56-
diff!(add "{}", r);
57-
}
58-
},
59-
)
43+
show_difflines(old, new, *DIFF_CHOICE.get().unwrap(), |res| match res {
44+
diff::Result::Left(l) => {
45+
diff!(del "{}", l);
46+
}
47+
diff::Result::Both(l, _) => {
48+
diff!("{}", l);
49+
}
50+
diff::Result::Right(r) => {
51+
diff!(add "{}", r);
52+
}
53+
})
6054
}
6155

6256
fn show_difflines(old: &str, new: &str, diff: DiffChoice, out: impl Fn(diff::Result<&str>)) {

src/main.rs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,11 @@ struct Cli {
4040

4141
#[cfg_attr(coverage_nightly, coverage(off))]
4242
fn main() {
43-
std::panic::set_hook(Box::new(
44-
#[cfg_attr(coverage_nightly, coverage(off))]
45-
|info| {
46-
if let Some(info) = info.payload().downcast_ref::<&str>() {
47-
error!("Fatal": "{}", info);
48-
}
49-
},
50-
));
43+
std::panic::set_hook(Box::new(|info| {
44+
if let Some(info) = info.payload().downcast_ref::<&str>() {
45+
error!("Fatal": "{}", info);
46+
}
47+
}));
5148

5249
let args = Cli::parse();
5350

src/upgrade.rs

Lines changed: 45 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -103,65 +103,55 @@ struct TypstDepUpgrader {
103103
impl TypstDepUpgrader {
104104
#[cfg_attr(coverage_nightly, coverage(off))]
105105
fn build(dep: &TypstDep) -> Self {
106-
static TYPST_PACKAGE_META: Lazy<HashMap<String, Vec<Version>>> = Lazy::new(
107-
#[cfg_attr(coverage_nightly, coverage(off))]
108-
|| {
109-
let mut retry_count = 5;
110-
let resp = loop {
111-
match reqwest::blocking::get("https://packages.typst.org/preview/index.json") {
112-
Ok(resp) => break resp,
113-
Err(_) if retry_count > 0 => {
114-
retry_count -= 1;
115-
warn!(
116-
"Failed to fetch package metadata, retrying... ({} attempts left)",
117-
retry_count,
118-
);
119-
}
120-
Err(_) => panic!("Failed to fetch package metadata"),
106+
static TYPST_PACKAGE_META: Lazy<HashMap<String, Vec<Version>>> = Lazy::new(|| {
107+
let mut retry_count = 5;
108+
let resp = loop {
109+
match reqwest::blocking::get("https://packages.typst.org/preview/index.json") {
110+
Ok(resp) => break resp,
111+
Err(_) if retry_count > 0 => {
112+
retry_count -= 1;
113+
warn!(
114+
"Failed to fetch package metadata, retrying... ({} attempts left)",
115+
retry_count,
116+
);
121117
}
122-
};
123-
let raw_meta = resp
124-
.json::<serde_json::Value>()
125-
.expect("Failed to parse package metadata")
126-
.as_array()
127-
.expect("Invalid package metadata")
128-
.iter()
129-
.map(
130-
#[cfg_attr(coverage_nightly, coverage(off))]
131-
|v| {
132-
let package = v.as_object().expect("Invalid package metadata");
133-
let name = package
134-
.get("name")
135-
.expect("Package name not found")
136-
.as_str()
137-
.unwrap();
138-
let version = Version::parse(
139-
package
140-
.get("version")
141-
.expect("Package version not found")
142-
.as_str()
143-
.unwrap(),
144-
)
145-
.unwrap();
146-
(name.to_string(), version)
147-
},
148-
)
149-
.collect::<Vec<_>>();
150-
151-
let mut result = HashMap::new();
152-
for (name, version) in raw_meta {
153-
result.entry(name).or_insert_with(Vec::new).push(version);
118+
Err(_) => panic!("Failed to fetch package metadata"),
154119
}
120+
};
121+
let raw_meta = resp
122+
.json::<serde_json::Value>()
123+
.expect("Failed to parse package metadata")
124+
.as_array()
125+
.expect("Invalid package metadata")
126+
.iter()
127+
.map(|v| {
128+
let package = v.as_object().expect("Invalid package metadata");
129+
let name = package
130+
.get("name")
131+
.expect("Package name not found")
132+
.as_str()
133+
.unwrap();
134+
let version = Version::parse(
135+
package
136+
.get("version")
137+
.expect("Package version not found")
138+
.as_str()
139+
.unwrap(),
140+
)
141+
.unwrap();
142+
(name.to_string(), version)
143+
})
144+
.collect::<Vec<_>>();
145+
146+
let mut result = HashMap::new();
147+
for (name, version) in raw_meta {
148+
result.entry(name).or_insert_with(Vec::new).push(version);
149+
}
155150

156-
result
157-
},
158-
);
151+
result
152+
});
159153

160-
Self::build_with_query(
161-
dep,
162-
#[cfg_attr(coverage_nightly, coverage(off))]
163-
|name| TYPST_PACKAGE_META.get(name).cloned(),
164-
)
154+
Self::build_with_query(dep, |name| TYPST_PACKAGE_META.get(name).cloned())
165155
}
166156

167157
fn build_with_query<Q, R>(dep: &TypstDep, query: Q) -> Self

0 commit comments

Comments
 (0)