Merge pull request #45 from CommunityGD32Cores/f/i2c-timeouts

maxgerhardt · web-flow · commit f2babd50a608 · 2021-10-02T07:55:16.000+02:00
The underlying i2c implementation would always block infinitely on reads
diff --git a/libraries/Wire/src/utility/twi.c b/libraries/Wire/src/utility/twi.c
@@ -347,7 +347,7 @@ i2c_status_enum i2c_master_receive(i2c_t *obj, uint8_t address, uint8_t *data, u
             }
         }
         timeout = FLAG_TIMEOUT;
-        while(!i2c_flag_get(obj->i2c, I2C_FLAG_RBNE));
+        while((!i2c_flag_get(obj->i2c, I2C_FLAG_RBNE)) && (--timeout != 0));
         data[count] = i2c_data_receive(obj->i2c);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ i2c_status_enum i2c_master_receive(i2c_t obj, uint8_t address, uint8_t data, u`
`347`	`347`	`}`
`348`	`348`	`}`
`349`	`349`	`timeout = FLAG_TIMEOUT;`
`350`		`- while(!i2c_flag_get(obj->i2c, I2C_FLAG_RBNE));`
	`350`	`+ while((!i2c_flag_get(obj->i2c, I2C_FLAG_RBNE)) && (--timeout != 0));`
`351`	`351`	`data[count] = i2c_data_receive(obj->i2c);`
`352`	`352`	`}`
`353`	`353`