FIXUP: runner

Author: cbandy

internal/controller/runtime/api_discovery.go

@@ -25,7 +25,6 @@ import (
 	"k8s.io/apimachinery/pkg/util/sets"
 	"k8s.io/client-go/discovery"
 	"k8s.io/client-go/rest"
-	"sigs.k8s.io/controller-runtime/pkg/manager"
 
 	"github.com/crunchydata/postgres-operator/internal/logging"
 )
@@ -98,10 +97,6 @@ type APIDiscoveryRunner struct {
 	}
 }
 
-// APIDiscoveryRunner implements [APIs] and [manager.Runnable].
-var _ APIs = (*APIDiscoveryRunner)(nil)
-var _ manager.Runnable = (*APIDiscoveryRunner)(nil)
-
 // NewAPIDiscoveryRunner creates an [APIDiscoveryRunner] that periodically reads
 // what APIs are available in the Kubernetes at config.
 func NewAPIDiscoveryRunner(config *rest.Config) (*APIDiscoveryRunner, error) {
@@ -122,7 +117,7 @@ func NewAPIDiscoveryRunner(config *rest.Config) (*APIDiscoveryRunner, error) {
 	return runner, err
 }
 
-// NeedLeaderElection returns false so that r runs any [manager.Manager],
+// NeedLeaderElection returns false so that r runs on any [manager.Manager],
 // regardless of which is elected leader in the Kubernetes namespace.
 func (r *APIDiscoveryRunner) NeedLeaderElection() bool { return false }
 

internal/controller/runtime/api_discovery_test.go

@@ -19,6 +19,7 @@ import (
 	"testing"
 
 	"gotest.tools/v3/assert"
+	"sigs.k8s.io/controller-runtime/pkg/manager"
 )
 
 func TestAPISet(t *testing.T) {
@@ -74,3 +75,11 @@ func TestAPIContext(t *testing.T) {
 	set[API{Group: "snapshot.storage.k8s.io"}] = struct{}{}
 	assert.Assert(t, Kubernetes(ctx).Has(API{Group: "snapshot.storage.k8s.io"}))
 }
+
+func TestAPIDiscoveryRunnerInterfaces(t *testing.T) {
+	var _ APIs = new(APIDiscoveryRunner)
+	var _ manager.Runnable = new(APIDiscoveryRunner)
+
+	var runnable manager.LeaderElectionRunnable = new(APIDiscoveryRunner)
+	assert.Assert(t, false == runnable.NeedLeaderElection())
+}