-
-
Notifications
You must be signed in to change notification settings - Fork 13
Update [email protected]
#1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
is there any replacement for |
Feel free to pullrequest a solution. |
I assumed that ajv-formats is a drop-in replacement for ajv-formats-draft2019 but that might not be the case. there are other people writing here: Do you want me or the developers of this project to propose a solution in how to migrate from the abandoned third-party dep ajv-formats-draft2019 ? |
today, there is simply no migration path. we are "stuck" with currently, I would be happy to review any pull request modernizing our dependencies. |
BTW: the JSON-validation is pluggable andextensible. https://github.com/CycloneDX/cyclonedx-javascript-library/blob/main/src/_optPlug.node/jsonValidator.ts implementation with |
after reading our code, I noticed
offer still stands: feel free to rework/replace the things. PS: even crafting our own validator with the help of some libs would be acceptable/feasible - see luzlab/ajv-formats-draft2019#22 (comment) |
I made a PR here; #1226. FYI used cursor IDE and ran the tests and it claims that https://ajv.js.org/guide/formats.html says:
Mabye a good next step is to copy the email format validation from the ajv-formats-draft2019) library? |
then, go ahead, if you must. remember: copy foreign code falls under licensing and other rights. check carefully what you do there. |
Ok, will look into in when I have some time over, I noted that ajv-formats-draft2019 is licensed under MIT which is ok. |
MIT, eh? then dont forget to include the original license, as the MIT license requires to do
|
When running cyclondedx v 2.1.0 on node 22 I get:
The issue stems from this library using an outdated third-party dep, this is the dep tree;
https://www.npmjs.com/package/ajv-formats-draft2019 is 4 years old and can be updated.
See also CycloneDX/cyclonedx-webpack-plugin#1348 that was closed
The text was updated successfully, but these errors were encountered: