Skip to content

Commit 7efcb7b

Browse files
authored
Make docker dev environment more distinct (#82)
When working on the [charging-module-api Docker dev environment](https://github.com/DEFRA/charging-module-api/pull/175) we realised that the volume names used in the Docker compose were pretty generic. So resolved this in the charging-module by prefixing `cha_` to the names. This change is just about solving the same issue in this project and ensuring we don't inadvertently overwrite or remove another service's volumes.
1 parent 51557df commit 7efcb7b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: docker-compose.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ services:
44
db:
55
image: postgres:10-alpine
66
volumes:
7-
- db_volume:/var/lib/postgresql/data
7+
- cma_db_volume:/var/lib/postgresql/data
88
ports:
99
- "54320:5432"
1010
env_file:
@@ -37,7 +37,7 @@ services:
3737
- ./package-lock.json:/home/node/package-lock.json
3838
# This is a workaround to prevent the host node_modules from accidently getting mounted in the container in case
3939
# you want to use either `node` or `npm` outside it, for example, to run linting.
40-
- notused:/home/node/app/node_modules
40+
- cma_notused:/home/node/app/node_modules
4141
env_file:
4242
- .env
4343
# Run these services first before you run this one. Note, it does not wait or check to ensure the service is fully
@@ -46,5 +46,5 @@ services:
4646
- db
4747

4848
volumes:
49-
db_volume:
50-
notused:
49+
cma_db_volume:
50+
cma_notused:

0 commit comments

Comments
 (0)