Skip to content

Commit bdc66a4

Browse files
committed
core_float_math: Move functions to math folder
When these functions were added in rust-lang#138087 It made a relatively common pattern for emulating these functions using an extension trait (which internally uses `libm`) much more fragile. If `core::f32` happened to be imported by the user (to access a constant, say), then that import in the module namespace would take precedence over `f32` in the type namespace for resolving these functions, running headfirst into the stability attribute. We ran into this in Color - https://github.com/linebender/color - and chose to release the remedial 0.3.1 and 0.2.4, to allow downstream crates to build on `docs.rs`. As these methods are perma-unstable, moving them into a new module should not have any long-term concerns, and ensures that this breakage doesn't adversely impact anyone else.
1 parent a8e4c68 commit bdc66a4

File tree

6 files changed

+990
-933
lines changed

6 files changed

+990
-933
lines changed

0 commit comments

Comments
 (0)