Skip to content

Commit 317796f

Browse files
Shankar Raohghotra
Shankar Rao
andauthored
When headers is set to null return undefined (#86)
Co-authored-by: Harvinder Ghotra <[email protected]>
1 parent 8ab3c90 commit 317796f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/trace/context.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,10 @@ describe("readTraceFromEvent", () => {
226226
const result = readTraceFromEvent({});
227227
expect(result).toBeUndefined();
228228
});
229+
it("returns undefined when headers is null", () => {
230+
const result = readTraceFromEvent("some-value");
231+
expect(result).toBeUndefined();
232+
});
229233
it("returns undefined when event isn't object", () => {
230234
const result = readTraceFromEvent("some-value");
231235
expect(result).toBeUndefined();

src/trace/context.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ export function readTraceFromEvent(event: any): TraceContext | undefined {
147147
}
148148
const headers = event.headers;
149149

150-
if (typeof headers !== "object") {
150+
// e.g. When lambda is invoked synchronously, headers can be set to null by the caller
151+
if (!headers || typeof headers !== "object") {
151152
return;
152153
}
153154

0 commit comments

Comments
 (0)