feat: Move log line to public metric method (#280)

* feat: Move log line to public metric method

* Update src/metrics/listener.ts

Co-authored-by: Harvinder Ghotra <[email protected]>

* fix: lint

Co-authored-by: Harvinder Ghotra <[email protected]>

Author: astuyve

src/metrics/listener.ts

@@ -56,6 +56,7 @@ export class MetricsListener {
 
   constructor(private kmsClient: KMSService, private config: MetricsConfig) {
     this.apiKey = this.getAPIKey(config);
+    this.config = config;
   }
 
   public async onStartInvocation(_: any) {
@@ -143,6 +144,11 @@ export class MetricsListener {
 
     const dist = new Distribution(name, [{ timestamp: metricTime, value }], ...tags);
 
+    if (!this.apiKey) {
+      const errorMessage = "api key not configured, see https://dtdg.co/sls-node-metrics";
+      logError(errorMessage);
+      return;
+    }
     if (this.currentProcessor !== undefined) {
       // tslint:disable-next-line: no-floating-promises
       this.currentProcessor.then((processor) => {
@@ -179,13 +185,6 @@ export class MetricsListener {
           logError("couldn't decrypt kms api key", error as Error);
         }
       }
-    } else {
-      const errorMessage = "api key not configured, see https://dtdg.co/sls-node-metrics";
-      if (config.logForwarding || this.isAgentRunning) {
-        logDebug(errorMessage);
-      } else {
-        logError(errorMessage);
-      }
     }
     return "";
   }