Skip to content

RUMM-647 Add the Span.setError API for Objc #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2021
Merged

RUMM-647 Add the Span.setError API for Objc #390

merged 2 commits into from
Jan 28, 2021

Conversation

acgh
Copy link
Contributor

@acgh acgh commented Jan 28, 2021

What and why?

This is the objc counter part of #388 where we introduced OTSpan.setError convenience API.

How?

The DatadogObjc @objc protocol and class merely proxy the calls that go to Datadog.OTSpan eventually.

Note that this PR also updates api-surface-objc with many changes from previous PRs so it's a bit noisy.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@acgh acgh self-assigned this Jan 28, 2021
@acgh acgh requested a review from a team as a code owner January 28, 2021 14:40
@acgh acgh merged commit ecd20e2 into master Jan 28, 2021
@acgh acgh deleted the acgh/RUMM-647-objc-add-span-seterror-api branch January 28, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buranmert buranmert buranmert approved these changes

Assignees

@acgh acgh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acgh @buranmert