Skip to content

Commit 063a99c

Browse files
authored
Don't use strict trace writing for vertx sql tests (#8662)
1 parent 09b7c65 commit 063a99c

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

dd-java-agent/instrumentation/vertx-mysql-client-3.9/src/test/groovy/VertxSqlClientForkedTest.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,13 @@ class VertxSqlClientForkedTest extends AgentTestRunner {
3737
@Shared
3838
def vertx = Vertx.vertx(new VertxOptions())
3939

40+
@Override
41+
boolean useStrictTraceWrites() {
42+
// given how the test without parent is done, we cannot guarantee that the handler callback finishes always
43+
// after the sql span since things are going asynchronously. Indeed we should not enforce that unbuffered write.
44+
false
45+
}
46+
4047
def "test #type"() {
4148
when:
4249
AsyncResult<RowSet<Row>> asyncResult = runUnderTrace("parent") {

dd-java-agent/instrumentation/vertx-mysql-client-4.0/src/test/groovy/VertxSqlClientForkedTest.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,13 @@ class VertxSqlClientForkedTest extends AgentTestRunner {
3939
@Shared
4040
def vertx = Vertx.vertx(new VertxOptions())
4141

42+
@Override
43+
boolean useStrictTraceWrites() {
44+
// given how the test without parent is done, we cannot guarantee that the handler callback finishes always
45+
// after the sql span since things are going asynchronously. Indeed we should not enforce that unbuffered write.
46+
false
47+
}
48+
4249
def "test #type"() {
4350
when:
4451
AsyncResult<RowSet<Row>> asyncResult = runUnderTrace("parent") {

0 commit comments

Comments
 (0)