disable testing of UnorderedThreadPoolEventExecutor

Author: richardstartin

dd-java-agent/instrumentation/java-concurrent/src/test/groovy/CrossedContextTest.groovy

@@ -5,7 +5,6 @@ import io.netty.channel.ThreadPerChannelEventLoop
 import io.netty.channel.nio.NioEventLoopGroup
 import io.netty.channel.oio.OioEventLoopGroup
 import io.netty.util.concurrent.DefaultEventExecutor
-import io.netty.util.concurrent.UnorderedThreadPoolEventExecutor
 import org.apache.tomcat.util.threads.TaskQueue
 import spock.lang.Shared
 
@@ -133,8 +132,9 @@ class CrossedContextTest extends AgentTestRunner {
       new ThreadPerChannelEventLoop(new OioEventLoopGroup()),
       new DefaultEventExecutor(),
       new NioEventLoopGroup(10),
-      new DefaultEventLoopGroup(10),
-      new UnorderedThreadPoolEventExecutor(10)
+      new DefaultEventLoopGroup(10)
+      // flaky
+      // new UnorderedThreadPoolEventExecutor(10)
     ]
   }
 

dd-java-agent/instrumentation/java-concurrent/src/test/groovy/NettyExecutorInstrumentationTest.groovy

@@ -6,7 +6,6 @@ import io.netty.channel.epoll.EpollEventLoopGroup
 import io.netty.channel.local.LocalEventLoopGroup
 import io.netty.channel.nio.NioEventLoopGroup
 import io.netty.util.concurrent.DefaultEventExecutorGroup
-import io.netty.util.concurrent.UnorderedThreadPoolEventExecutor
 import spock.lang.Shared
 
 import java.lang.reflect.InvocationTargetException
@@ -84,16 +83,16 @@ class NettyExecutorInstrumentationTest extends AgentTestRunner {
 
     where:
     name                     | method              | poolImpl
-
-    "execute Runnable"       | executeRunnable     | new UnorderedThreadPoolEventExecutor(1)
-    "submit Runnable"        | submitRunnable      | new UnorderedThreadPoolEventExecutor(1)
-    "submit Callable"        | submitCallable      | new UnorderedThreadPoolEventExecutor(1)
-    "invokeAll"              | invokeAll           | new UnorderedThreadPoolEventExecutor(1)
-    "invokeAll with timeout" | invokeAllTimeout    | new UnorderedThreadPoolEventExecutor(1)
-    "invokeAny"              | invokeAny           | new UnorderedThreadPoolEventExecutor(1)
-    "invokeAny with timeout" | invokeAnyTimeout    | new UnorderedThreadPoolEventExecutor(1)
-    "schedule Runnable"      | scheduleRunnable    | new UnorderedThreadPoolEventExecutor(1)
-    "schedule Callable"      | scheduleCallable    | new UnorderedThreadPoolEventExecutor(1)
+// TODO flaky
+//    "execute Runnable"       | executeRunnable     | new UnorderedThreadPoolEventExecutor(1)
+//    "submit Runnable"        | submitRunnable      | new UnorderedThreadPoolEventExecutor(1)
+//    "submit Callable"        | submitCallable      | new UnorderedThreadPoolEventExecutor(1)
+//    "invokeAll"              | invokeAll           | new UnorderedThreadPoolEventExecutor(1)
+//    "invokeAll with timeout" | invokeAllTimeout    | new UnorderedThreadPoolEventExecutor(1)
+//    "invokeAny"              | invokeAny           | new UnorderedThreadPoolEventExecutor(1)
+//    "invokeAny with timeout" | invokeAnyTimeout    | new UnorderedThreadPoolEventExecutor(1)
+//    "schedule Runnable"      | scheduleRunnable    | new UnorderedThreadPoolEventExecutor(1)
+//    "schedule Callable"      | scheduleCallable    | new UnorderedThreadPoolEventExecutor(1)
 
     "execute Runnable"       | executeRunnable     | defaultEventExecutorGroup
     "submit Runnable"        | submitRunnable      | defaultEventExecutorGroup
@@ -242,11 +241,11 @@ class NettyExecutorInstrumentationTest extends AgentTestRunner {
 
     where:
     name                     | method              | poolImpl
-
-    "submit Runnable"        | submitRunnable      | new UnorderedThreadPoolEventExecutor(1)
-    "submit Callable"        | submitCallable      | new UnorderedThreadPoolEventExecutor(1)
-    "schedule Runnable"      | scheduleRunnable    | new UnorderedThreadPoolEventExecutor(1)
-    "schedule Callable"      | scheduleCallable    | new UnorderedThreadPoolEventExecutor(1)
+// TODO flaky
+//    "submit Runnable"        | submitRunnable      | new UnorderedThreadPoolEventExecutor(1)
+//    "submit Callable"        | submitCallable      | new UnorderedThreadPoolEventExecutor(1)
+//    "schedule Runnable"      | scheduleRunnable    | new UnorderedThreadPoolEventExecutor(1)
+//    "schedule Callable"      | scheduleCallable    | new UnorderedThreadPoolEventExecutor(1)
 
     "submit Runnable"        | submitRunnable      | defaultEventExecutorGroup.next()
     "submit Callable"        | submitCallable      | defaultEventExecutorGroup.next()