Skip to content

Commit 3243261

Browse files
committed
Use lower priorities for grpc server errors
1 parent 9f01834 commit 3243261

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

dd-java-agent/instrumentation/armeria-grpc/src/main/java/datadog/trace/instrumentation/armeria/grpc/server/GrpcServerDecorator.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import datadog.trace.api.cache.DDCaches;
1010
import datadog.trace.api.naming.SpanNaming;
1111
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
12+
import datadog.trace.bootstrap.instrumentation.api.ErrorPriorities;
1213
import datadog.trace.bootstrap.instrumentation.api.InternalSpanTypes;
1314
import datadog.trace.bootstrap.instrumentation.api.UTF8BytesString;
1415
import datadog.trace.bootstrap.instrumentation.decorator.ServerDecorator;
@@ -102,7 +103,8 @@ public <RespT, ReqT> AgentSpan onCall(final AgentSpan span, ServerCall<ReqT, Res
102103
public AgentSpan onStatus(final AgentSpan span, final Status status) {
103104
span.setTag("status.code", status.getCode().name());
104105
span.setTag("status.description", status.getDescription());
105-
return span.setError(SERVER_ERROR_STATUSES.get(status.getCode().value()));
106+
return span.setError(
107+
SERVER_ERROR_STATUSES.get(status.getCode().value()), ErrorPriorities.HTTP_SERVER_DECORATOR);
106108
}
107109

108110
public AgentSpan onClose(final AgentSpan span, final Status status) {

dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/server/GrpcServerDecorator.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ public <RespT, ReqT> AgentSpan onCall(final AgentSpan span, ServerCall<ReqT, Res
102102
public AgentSpan onStatus(final AgentSpan span, final Status status) {
103103
span.setTag("status.code", status.getCode().name());
104104
span.setTag("status.description", status.getDescription());
105-
return span.setError(SERVER_ERROR_STATUSES.get(status.getCode().value()));
105+
return span.setError(
106+
SERVER_ERROR_STATUSES.get(status.getCode().value()), ErrorPriorities.HTTP_SERVER_DECORATOR);
106107
}
107108

108109
public AgentSpan onClose(final AgentSpan span, final Status status) {

0 commit comments

Comments
 (0)