You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* top right Settings icon -> `Settings...` ->`Editor` > `Code Style` > `Groovy` > `Imports`
60
+
*`Class count to use import with '*'`: `9999` (some number sufficiently large that is unlikely to matter)
61
+
*`Names count to use static import with '*'`: `9999`
62
+
* Install the [Google Java Format](https://plugins.jetbrains.com/plugin/8527-google-java-format) plugin
62
63
63
64
### Troubleshooting
64
65
65
66
* Gradle fails with a "too many open files" error.
66
-
* You can check the `ulimit` for open files in your current shell by doing`ulimit -n` and raise it by
67
-
calling`ulimit -n <new number>`
67
+
* You can check the `ulimit` for open files in your current shell by running`ulimit -n`.
68
+
* You can raise the `ulimit` by running`ulimit -n <new number>`
68
69
69
70
<details>
70
-
<summary>More past issues</summary>
71
+
<summary>Past issues</summary>
71
72
72
73
* When Gradle is building the project, the
73
74
error `Could not find netty-transport-native-epoll-4.1.43.Final-linux-x86_64.jar` is shown.
74
-
* Execute `rm -rf ~/.m2/repository/io/netty/netty-transport*` in a Terminal and re-build again.
75
+
* Execute `rm -rf ~/.m2/repository/io/netty/netty-transport*` in a Terminal and re-build.
75
76
76
77
* IntelliJ 2021.3
77
-
complains `Failed to find KotlinGradleProjectData for GradleSourceSetData`https://youtrack.jetbrains.com/issue/KTIJ-20173
78
-
* Switch to `IntelliJ IDEA CE 2021.2.3`
79
-
80
-
* IntelliJ Gradle fails to import the project with `JAVA_11_HOME must be set to build Java 11 code`
81
-
* A workaround is to run IntelliJ from terminal with `JAVA_11_HOME`
82
-
* In order to verify what's visible from IntelliJ use `Add Configuration` bar and go
83
-
to `Add New` -> `Gradle` -> `Environmental Variables`
78
+
complains `Failed to find KotlinGradleProjectData for GradleSourceSetData`https://youtrack.jetbrains.com/issue/KTIJ-20173.
79
+
* Switch to `IntelliJ IDEA CE 2021.2.3`.
84
80
81
+
* IntelliJ Gradle fails to import the project with `JAVA_11_HOME must be set to build Java 11 code`.
82
+
* A workaround is to run IntelliJ from your terminal with `JAVA_11_HOME`.
83
+
* In order to verify what's visible from IntelliJ, use the `Add Configuration` bar and go
84
+
to `Add New` -> `Gradle` -> `Environmental Variables`.
85
85
</details>
86
86
87
-
## Pull Request Guidelines
87
+
## Pull request guidelines
88
88
89
89
### Draft first
90
90
91
-
When opening a pull request, please open it as a [draft](https://github.blog/2019-02-14-introducing-draft-pull-requests/) to not autoassign reviewers before you feel the pull request is in a reviewable state.
91
+
When opening a pull request, please open it as a [draft](https://github.blog/2019-02-14-introducing-draft-pull-requests/) to not auto-assign reviewers before the pull request is in a reviewable state.
92
92
93
-
### Title Format
93
+
### Title format
94
94
95
95
Pull request titles should briefly describe the proposed changes in a way that makes sense for the users.
96
-
They should be a sentence starting with an infinitive verb, and avoid using prefixes like `[PROD]` or `PROD - ` in favor of [labels](#labels).
96
+
They should be a sentence starting with an infinitive verb and avoid using prefixes like `[PROD]` or `PROD - ` in favor of [labels](#labels).
97
97
98
98
>[!CAUTION]
99
99
> Don't title:
@@ -119,7 +119,7 @@ Both pull requests and issues should be labelled with at least a component or an
119
119
>[!TIP]
120
120
> Always add a `comp:` or `inst:` label, and a `type:` label.
121
121
122
-
Labels are not only used to categorize but also alter the continuous integration behavior:
122
+
Labels are used to not only categorize but also alter the continuous integration behavior:
123
123
124
124
*`tag: no release note` to exclude a pull request from the next release changelog. Use it when changes are not relevant to the users like:
125
125
* Internal features changes
@@ -133,16 +133,16 @@ Labels are not only used to categorize but also alter the continuous integration
133
133
> For reference, the [full list of all labels available](https://github.com/DataDog/dd-trace-java/labels).
134
134
> If you feel one is missing, let [the maintainer team](https://github.com/orgs/DataDog/teams/apm-java) know!
135
135
136
-
## Pull Request Reviews
136
+
## Pull request reviews
137
137
138
-
### Review Expectations
138
+
### Review expectations
139
139
140
-
After making you pull request ready for review by converting it from draft, you can expect getting an initial review comment within two working days, and a full review within a week of work.
140
+
After making your pull request ready for review by converting it from a draft, you can expect to get an initial review comment within two working days and a full review within a week of work.
141
141
If you don't receive any update, feel free to send a nice reminder to the assigned reviewers using pull request comments or our internal Slack channel.
142
142
143
-
### Stale Pull Requests
143
+
### Stale pull requests
144
144
145
145
A pull request is considered "stale" if it has had no activity (comments, updates) for the last quarter.
146
-
Stale PRs will be commented and labelled as such (using the `tag: stale` label), then closed if they still receive no update for a week after.
146
+
Stale PRs will be commented and labeled as such (using the `tag: stale` label), and then closed if they receive no update after a week.
147
147
148
-
Closed PRs can be reopened at any time, but may be closed again if they ever meet the same stale conditions.
148
+
Closed PRs can be reopened at any time, but they may be closed again if they meet the same stale conditions.
0 commit comments