Skip to content

Commit 3c24ea6

Browse files
authored
Revert "FIXME: temporarily ignore hostname assertions on CircleCI (#8411)" (#8422)
This reverts commit ebdbdd4.
1 parent 5bc1a33 commit 3c24ea6

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

dd-smoke-tests/profiling-integration-tests/src/test/java/datadog/smoketest/JFRBasedProfilingIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import java.io.ByteArrayInputStream;
2121
import java.io.File;
2222
import java.io.IOException;
23+
import java.net.InetAddress;
2324
import java.nio.file.Files;
2425
import java.nio.file.Path;
2526
import java.nio.file.Paths;
@@ -257,8 +258,7 @@ private void testContinuousRecording(
257258
assertEquals("smoke-test-java-app", requestTags.get("service"));
258259
assertEquals("jvm", requestTags.get("language"));
259260
assertNotNull(requestTags.get("runtime-id"));
260-
// FIXME: temporarily ignore this assertion on CircleCI
261-
// assertEquals(InetAddress.getLocalHost().getHostName(), requestTags.get("host"));
261+
assertEquals(InetAddress.getLocalHost().getHostName(), requestTags.get("host"));
262262

263263
assertFalse(logHasErrors(logFilePath));
264264
IItemCollection events = JfrLoaderToolkit.loadEvents(new ByteArrayInputStream(rawJfr.get()));

telemetry/src/test/groovy/datadog/telemetry/HostInfoTest.groovy

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ class HostInfoTest extends Specification {
3535
Assume.assumeTrue('uname -a'.execute().waitFor() == 0)
3636

3737
expect:
38-
// FIXME: temporarily ignore this assertion on CircleCI
39-
// HostInfo.getHostname() == 'uname -n'.execute().text.trim()
38+
HostInfo.getHostname() == 'uname -n'.execute().text.trim()
4039
HostInfo.getOsName() == 'uname -s'.execute().text.trim()
4140
HostInfo.getKernelName() == 'uname -s'.execute().text.trim()
4241
if (Platform.isMac()) {

0 commit comments

Comments
 (0)