Skip to content

Commit 4d01d58

Browse files
authored
Revert "Update config line to account for large binary files" (#8731)
* Revert "Adjust way to get changed files (#8709)" This reverts commit 7dc621f. * Patch AbstractSparkListenerTest * Force byte-buddy version for mule4
1 parent 75634fe commit 4d01d58

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

.circleci/config.continue.yml.j2

+1-2
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,7 @@ commands:
167167
if [[ "$BRANCH" != "master" ]] && [[ "$BRANCH" != "release/*" ]]; then
168168
# We know that we have checked out the PR merge branch, so the HEAD commit is a merge
169169
# As a backup, if anything goes wrong with the diff, the build will fail
170-
# Get list of changed files directly using git diff-tree to avoid issues with large binary files
171-
CHANGED_FILES=$(git diff-tree --no-commit-id --name-only -r HEAD)
170+
CHANGED_FILES=$(git show HEAD | grep -e "^Merge:" | cut -d ' ' -f 2- | sed 's/ /.../' | xargs git diff --name-only)
172171
# Count the number of matches, and ignore if the grep doesn't match anything
173172
MATCH_COUNT=$(echo "$CHANGED_FILES" | grep -c -E "<< pipeline.parameters.global_pattern >>|<< parameters.pattern >>") || true
174173
if [[ "$MATCH_COUNT" -eq "0" ]]; then

dd-java-agent/instrumentation/mule-4/build.gradle

+3-2
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ configurations.all {
7878
// avoid bringing in logback based on java 11
7979
force libs.logback.classic
8080
force libs.logback.core
81+
82+
// force specific version of byte-buddy for all configurations
83+
force 'net.bytebuddy:byte-buddy:1.14.18'
8184
}
8285
}
8386

@@ -146,7 +149,6 @@ dependencies {
146149
testImplementation project(':dd-java-agent:instrumentation:caffeine')
147150
testImplementation project(':dd-java-agent:instrumentation:quartz-2')
148151

149-
150152
testImplementation group: 'org.mule.runtime', name: 'mule-module-launcher', version: muleVersion
151153
testImplementation group: 'org.mule.runtime', name: 'mule-core', version: muleVersion
152154
//testImplementation group: 'org.mule.runtime', name: 'mule-module-extensions-spring-support', version: muleVersion
@@ -175,7 +177,6 @@ dependencies {
175177
latestDepForkedTestImplementation group: 'org.mule.runtime', name: 'mule-module-service', version: '4.8.+'
176178
latestDepForkedTestImplementation group: 'org.mule.runtime', name: 'mule-module-javaee', version: '4.8.+'
177179

178-
179180
//TODO: 4.9.0 is not yet out but it looks like using 4.+ instead of above 4.8.+ brings in 4.9.0-SNAPSHOT artifacts.
180181
/*
181182
When testing with them, the mule container does not bootstrap because of:

dd-java-agent/instrumentation/spark/src/testFixtures/groovy/datadog/trace/instrumentation/spark/AbstractSparkListenerTest.groovy

+13-2
Original file line numberDiff line numberDiff line change
@@ -475,9 +475,20 @@ abstract class AbstractSparkListenerTest extends AgentTestRunner {
475475
conf.set("spark.openlineage.rootParentJobName", "dag-push-to-s3-spark")
476476
def listener = getTestDatadogSparkListener(conf)
477477

478-
expect:
478+
when:
479479
listener.onApplicationStart(applicationStartEvent(1000L))
480-
assert listener.openLineageSparkConf.get("spark.openlineage.run.tags").contains("13959090542865903119")
480+
listener.onApplicationEnd(new SparkListenerApplicationEnd(2000L))
481+
482+
then:
483+
assertTraces(1) {
484+
trace(1) {
485+
span {
486+
operationName "spark.application"
487+
spanType "spark"
488+
assert span.context.traceId.toString() == "13959090542865903119"
489+
}
490+
}
491+
}
481492
}
482493

483494
def "test lastJobFailed is not set when job is cancelled"() {

0 commit comments

Comments
 (0)