Skip to content

Commit 4e79504

Browse files
authored
Remove restriction to not run vertx4 latest tests on java 17 (#8133)
* does this pass ? * Revert "does this pass ?" This reverts commit 57dc994. * use java 17 only for latest dep tests
1 parent 6ef294d commit 4e79504

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

dd-java-agent/instrumentation/vertx-web-4.0/build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// Set properties before any plugins get loaded
22
ext {
3-
// TODO Java 17: This version of vertx-web doesn't support Java 17
3+
// vertx-web doesn't support Java 17 until v4.2
44
maxJavaVersionForTests = JavaVersion.VERSION_15
5+
latestDepTestMaxJavaVersionForTests = JavaVersion.VERSION_17
56
}
67

78
apply from: "$rootDir/gradle/java.gradle"
@@ -29,7 +30,7 @@ artifacts {
2930
dependencies {
3031
api project(':dd-java-agent:instrumentation:netty-4.1-shared')
3132

32-
compileOnly group: 'io.vertx', name: 'vertx-web', version: '4.2.7'
33+
compileOnly group: 'io.vertx', name: 'vertx-web', version: '4.0.0'
3334

3435
testImplementation project(':dd-java-agent:instrumentation:netty-4.1')
3536
testImplementation project(':dd-java-agent:instrumentation:trace-annotation')
@@ -44,6 +45,7 @@ dependencies {
4445
testRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core')
4546
testRuntimeOnly project(':dd-java-agent:instrumentation:netty-buffer-4')
4647

48+
// TODO support v>=4.5
4749
latestDepTestImplementation group: 'io.vertx', name: 'vertx-web', version: '4.4.+'
4850
latestDepTestImplementation group: 'io.vertx', name: 'vertx-web-client', version: '4.4.+'
4951
}

0 commit comments

Comments
 (0)