smola advice implemented wip

sezen-datadog · sezen-datadog · commit 531668a919a4 · 2025-05-26T17:36:27.000+02:00
Signed-off-by: sezen.leblay &lt;sezen.leblay@datadoghq.com&gt;
diff --git a/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet31ResponseBodyInstrumentation.java b/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet31ResponseBodyInstrumentation.java
@@ -35,7 +35,7 @@ public String muzzleDirective() {
   @Override
   public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
     // Avoid matching response bodies before 3.1.x which have their own instrumentation
-    return hasClassNamed("javax.servlet.ReadListener");
+    return hasClassNamed("javax.servlet.WriteListener");
   }
 
   @Override
diff --git a/dd-java-agent/instrumentation/servlet/src/main/java/datadog/trace/instrumentation/servlet/http/HttpServletResponseInstrumentation.java b/dd-java-agent/instrumentation/servlet/src/main/java/datadog/trace/instrumentation/servlet/http/HttpServletResponseInstrumentation.java
@@ -50,7 +50,6 @@ public void methodAdvice(MethodTransformer transformer) {
     transformer.applyAdvice(
         namedOneOf("sendError", "sendRedirect"),
         HttpServletResponseInstrumentation.class.getName() + "$SendAdvice");
-    // TODO here
   }
 
   public static class SendAdvice {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public String muzzleDirective() {`
`35`	`35`	`@Override`
`36`	`36`	`public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {`
`37`	`37`	`// Avoid matching response bodies before 3.1.x which have their own instrumentation`
`38`		`- return hasClassNamed("javax.servlet.ReadListener");`
	`38`	`+ return hasClassNamed("javax.servlet.WriteListener");`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,6 @@ public void methodAdvice(MethodTransformer transformer) {`
`50`	`50`	`transformer.applyAdvice(`
`51`	`51`	`namedOneOf("sendError", "sendRedirect"),`
`52`	`52`	`HttpServletResponseInstrumentation.class.getName() + "$SendAdvice");`
`53`		`- // TODO here`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`public static class SendAdvice {`