Replace StringBuilder#append(String) with StringBuilder#append(char)

smola · smola · commit 5a15ca95dbc0 · 2024-11-25T08:53:51.000+01:00
diff --git a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/StringTemplateBuilder.java b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/StringTemplateBuilder.java
@@ -56,7 +56,7 @@ public String evaluate(CapturedContext context, LogProbe.LogStatus status) {
             status.addError(new EvaluationError(ex.getExpr(), ex.getMessage()));
             String msg =
                 ex instanceof RedactedException ? Redaction.REDACTED_VALUE : ex.getMessage();
-            sb.append("{").append(msg).append("}");
+            sb.append('{').append(msg).append('}');
           }
           if (!status.getErrors().isEmpty()) {
             status.setLogTemplateErrors(true);
diff --git a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/ProbeDefinition.java b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/ProbeDefinition.java
@@ -85,7 +85,7 @@ public String concatTags() {
     StringBuilder sb = new StringBuilder();
     for (Tag tag : tags) {
       if (sb.length() > 0) {
-        sb.append(",");
+        sb.append(',');
       }
       sb.append(tag);
     }
diff --git a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/IntakeBatchHelper.java b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/IntakeBatchHelper.java
@@ -61,7 +61,7 @@ private static int buildPayloadBatch(
       List<String> payloads, int start, int count, StringBuilder sb) {
     int totalSize = 0;
     int elementCount = 0;
-    sb.append("[");
+    sb.append('[');
     for (int i = start; i < start + count; i++) {
       String jsonStr = payloads.get(i);
       totalSize += jsonStr.length();
@@ -71,13 +71,13 @@ private static int buildPayloadBatch(
         break;
       }
       sb.append(jsonStr);
-      sb.append(",");
+      sb.append(',');
       elementCount++;
     }
     if (elementCount > 0) {
       sb.delete(sb.lastIndexOf(","), sb.length());
     }
-    sb.append("]");
+    sb.append(']');
     return elementCount;
   }
 
diff --git a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/util/StringTokenWriter.java b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/util/StringTokenWriter.java
@@ -31,7 +31,7 @@ public StringTokenWriter(StringBuilder sb, List<EvaluationError> evalErrors) {
   @Override
   public void prologue(Object value, String type) {
     if (inMapEntry && !initial) {
-      sb.append("=");
+      sb.append('=');
     } else if (inCollection && !initial) {
       sb.append(", ");
     }
@@ -85,7 +85,7 @@ public void primitiveArrayElement(String value, String type) {
 
   @Override
   public void collectionPrologue(Object value) {
-    sb.append("[");
+    sb.append('[');
     initial = true;
     inCollection = true;
   }
@@ -98,7 +98,7 @@ public void collectionEpilogue(Object value, boolean isComplete, int size) {
 
   @Override
   public void mapPrologue(Object value) {
-    sb.append("{");
+    sb.append('{');
     initial = true;
     inCollection = true;
   }
@@ -108,14 +108,14 @@ public void mapEntryPrologue(Map.Entry<?, ?> entry) {
     if (!initial) {
       sb.append(", ");
     }
-    sb.append("[");
+    sb.append('[');
     initial = true;
     inMapEntry = true;
   }
 
   @Override
   public void mapEntryEpilogue(Map.Entry<?, ?> entry) {
-    sb.append("]");
+    sb.append(']');
     inMapEntry = false;
   }
 
@@ -127,7 +127,7 @@ public void mapEpilogue(boolean isComplete, int size) {
 
   @Override
   public void objectPrologue(Object value) {
-    sb.append("{");
+    sb.append('{');
     initial = true;
   }
 
@@ -137,12 +137,12 @@ public void objectFieldPrologue(String fieldName, Object value, int maxDepth) {
       sb.append(", ");
     }
     initial = false;
-    sb.append(fieldName).append("=");
+    sb.append(fieldName).append('=');
   }
 
   @Override
   public void objectEpilogue(Object value) {
-    sb.append("}");
+    sb.append('}');
   }
 
   @Override
@@ -167,16 +167,16 @@ public void notCaptured(SerializerWithLimits.NotCapturedReason reason) {
         sb.append("...");
         break;
       case TIMEOUT:
-        sb.append("{").append(TIMEOUT_REASON).append("}");
+        sb.append('{').append(TIMEOUT_REASON).append('}');
         break;
       case FIELD_COUNT:
         sb.append(", ...");
         break;
       case REDACTED_IDENT:
-        sb.append("{").append(REDACTED_IDENT_REASON).append("}");
+        sb.append('{').append(REDACTED_IDENT_REASON).append('}');
         break;
       case REDACTED_TYPE:
-        sb.append("{").append(REDACTED_TYPE_REASON).append("}");
+        sb.append('{').append(REDACTED_TYPE_REASON).append('}');
         break;
       default:
         throw new RuntimeException("Unsupported NotCapturedReason: " + reason);
@@ -185,6 +185,6 @@ public void notCaptured(SerializerWithLimits.NotCapturedReason reason) {
 
   @Override
   public void notCaptured(String reason) throws Exception {
-    sb.append("(Error: ").append(reason).append(")");
+    sb.append("(Error: ").append(reason).append(')');
   }
 }
diff --git a/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/sink/DebuggerSinkTest.java b/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/sink/DebuggerSinkTest.java
@@ -322,7 +322,7 @@ public void splitDiagnosticsBatch() {
     DebuggerSink sink = createDebuggerSink(diagnosticUploader, false);
     StringBuilder largeMessageBuilder = new StringBuilder(100_001);
     for (int i = 0; i < 100_000; i++) {
-      largeMessageBuilder.append("f");
+      largeMessageBuilder.append('f');
     }
     String largeMessage = largeMessageBuilder.toString();
     for (int i = 0; i < 100; i++) {
@@ -342,7 +342,7 @@ public void splitDiagnosticsBatchDebuggerTrack() {
     DebuggerSink sink = createDebuggerSink(diagnosticUploader, true);
     StringBuilder largeMessageBuilder = new StringBuilder(100_001);
     for (int i = 0; i < 100_000; i++) {
-      largeMessageBuilder.append("f");
+      largeMessageBuilder.append('f');
     }
     String largeMessage = largeMessageBuilder.toString();
     for (int i = 0; i < 100; i++) {
@@ -362,7 +362,7 @@ public void tooLargeDiagnostic() {
     DebuggerSink sink = createDefaultDebuggerSink();
     StringBuilder tooLargeMessageBuilder = new StringBuilder(MAX_PAYLOAD + 1);
     for (int i = 0; i < MAX_PAYLOAD; i++) {
-      tooLargeMessageBuilder.append("f");
+      tooLargeMessageBuilder.append('f');
     }
     String tooLargeMessage = tooLargeMessageBuilder.toString();
     sink.getProbeDiagnosticsSink().addError(new ProbeId("1", 1), tooLargeMessage);
diff --git a/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/util/CapturedValueAdapterTest.java b/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/util/CapturedValueAdapterTest.java
@@ -55,7 +55,7 @@ void collection() throws IOException {
     StringBuilder sb = new StringBuilder();
     for (int i = 0; i < 10; i++) {
       if (i > 0) {
-        sb.append(",");
+        sb.append(',');
       }
       sb.append(String.format(CAPTURED_VALUE_SIMPLE_TEMPLATE, int.class.getTypeName(), i));
     }
@@ -66,7 +66,7 @@ void collection() throws IOException {
     sb = new StringBuilder();
     for (int i = 0; i < 10; i++) {
       if (i > 0) {
-        sb.append(",");
+        sb.append(',');
       }
       sb.append(
           String.format(CAPTURED_VALUE_SIMPLE_TEMPLATE, String.class.getTypeName(), "foo" + i));
diff --git a/dd-java-agent/agent-logging/src/main/java/datadog/trace/logging/simplelogger/SLCompatHelper.java b/dd-java-agent/agent-logging/src/main/java/datadog/trace/logging/simplelogger/SLCompatHelper.java
@@ -108,12 +108,12 @@ private void embedException(StringBuilder buf, Throwable t) {
     if (t != null) {
       buf.append(" [exception:");
       buf.append(t.toString());
-      buf.append(".");
+      buf.append('.');
       for (StackTraceElement element : t.getStackTrace()) {
         buf.append(" at ");
         buf.append(element.toString());
       }
-      buf.append("]");
+      buf.append(']');
     }
   }
 }
diff --git a/dd-java-agent/agent-logs-intake/src/main/java/datadog/trace/logging/intake/LogsDispatcher.java b/dd-java-agent/agent-logs-intake/src/main/java/datadog/trace/logging/intake/LogsDispatcher.java
@@ -66,21 +66,21 @@ public void dispatch(List<Map<String, Object>> messages) {
       }
 
       if (batchCount + 1 > maxBatchRecords || batchLength + bytes.length >= maxBatchBytes) {
-        flush(batch.append("]"));
+        flush(batch.append(']'));
         batch = new StringBuilder("[");
         batchCount = 0;
         batchLength = 0;
       }
 
       if (batchCount != 0) {
-        batch.append(",");
+        batch.append(',');
       }
       batch.append(json);
       batchCount += 1;
       batchLength += bytes.length;
     }
 
-    flush(batch.append("]"));
+    flush(batch.append(']'));
   }
 
   private void flush(StringBuilder batch) {
diff --git a/dd-java-agent/agent-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java b/dd-java-agent/agent-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java
@@ -299,7 +299,7 @@ String cmdStartProfiling(Path file) throws IllegalStateException {
       // wall profiling is enabled.
       cmd.append(",wall=");
       if (getWallCollapsing(configProvider)) {
-        cmd.append("~");
+        cmd.append('~');
       }
       cmd.append(getWallInterval(configProvider)).append('m');
       if (getWallContextFilter(configProvider)) {
diff --git a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/InstrumenterMetrics.java b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/InstrumenterMetrics.java
@@ -206,7 +206,7 @@ private static void summarize(StringBuilder buf, String prefix, AtomicLong stat)
     long value = stat.get();
     buf.append(prefix)
         .append(String.format("%-12d", value >>> COUNT_SHIFT))
-        .append(" ")
+        .append(' ')
         .append(String.format("%.1f", (value & NANOS_MASK) / 1_000_000.0))
         .append(" ms\n");
   }
diff --git a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java
@@ -159,12 +159,12 @@ private static String prettyPrint(final String prefix, final Reference ref) {
     builder.append(Reference.prettyPrint(ref.flags));
     builder.append(ref.className);
     if (ref.superName != null) {
-      builder.append(" extends<").append(ref.superName).append(">");
+      builder.append(" extends<").append(ref.superName).append('>');
     }
     if (ref.interfaces.length > 0) {
       builder.append(" implements ");
       for (final String iface : ref.interfaces) {
-        builder.append(" <").append(iface).append(">");
+        builder.append(" <").append(iface).append('>');
       }
     }
     for (final String source : ref.sources) {
diff --git a/dd-java-agent/instrumentation/aws-java-sns-1.0/src/main/java/datadog/trace/instrumentation/aws/v1/sns/SnsInterceptor.java b/dd-java-agent/instrumentation/aws-java-sns-1.0/src/main/java/datadog/trace/instrumentation/aws/v1/sns/SnsInterceptor.java
@@ -36,13 +36,13 @@ private ByteBuffer getMessageAttributeValueToInject(
       AmazonWebServiceRequest request, String snsTopicName) {
     final AgentSpan span = newSpan(request);
     StringBuilder jsonBuilder = new StringBuilder();
-    jsonBuilder.append("{");
+    jsonBuilder.append('{');
     propagate().inject(span, jsonBuilder, SETTER, TracePropagationStyle.DATADOG);
     if (traceConfig().isDataStreamsEnabled()) {
       propagate().injectPathwayContext(span, jsonBuilder, SETTER, getTags(snsTopicName));
     }
     jsonBuilder.setLength(jsonBuilder.length() - 1); // Remove the last comma
-    jsonBuilder.append("}");
+    jsonBuilder.append('}');
     return ByteBuffer.wrap(jsonBuilder.toString().getBytes(StandardCharsets.UTF_8));
   }
 
diff --git a/dd-java-agent/instrumentation/aws-java-sns-2.0/src/main/java/datadog/trace/instrumentation/aws/v2/sns/SnsInterceptor.java b/dd-java-agent/instrumentation/aws-java-sns-2.0/src/main/java/datadog/trace/instrumentation/aws/v2/sns/SnsInterceptor.java
@@ -36,13 +36,13 @@ private SdkBytes getMessageAttributeValueToInject(
       ExecutionAttributes executionAttributes, String snsTopicName) {
     final AgentSpan span = executionAttributes.getAttribute(SPAN_ATTRIBUTE);
     StringBuilder jsonBuilder = new StringBuilder();
-    jsonBuilder.append("{");
+    jsonBuilder.append('{');
     propagate().inject(span, jsonBuilder, SETTER);
     if (traceConfig().isDataStreamsEnabled()) {
       propagate().injectPathwayContext(span, jsonBuilder, SETTER, getTags(snsTopicName));
     }
     jsonBuilder.setLength(jsonBuilder.length() - 1); // Remove the last comma
-    jsonBuilder.append("}");
+    jsonBuilder.append('}');
     return SdkBytes.fromString(jsonBuilder.toString(), StandardCharsets.UTF_8);
   }
 
diff --git a/dd-java-agent/instrumentation/jakarta-rs-annotations-3/src/main/java/datadog/trace/instrumentation/jakarta3/JakartaRsAnnotationsDecorator.java b/dd-java-agent/instrumentation/jakarta-rs-annotations-3/src/main/java/datadog/trace/instrumentation/jakarta3/JakartaRsAnnotationsDecorator.java
@@ -179,7 +179,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {
     boolean skipSlash = false;
     if (classPath != null) {
       if (!classPath.value().startsWith("/")) {
-        route.append("/");
+        route.append('/');
       }
       route.append(classPath.value());
       skipSlash = classPath.value().endsWith("/");
@@ -192,7 +192,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {
           path = path.length() == 1 ? "" : path.substring(1);
         }
       } else if (!path.startsWith("/")) {
-        route.append("/");
+        route.append('/');
       }
       route.append(path);
     }
diff --git a/dd-java-agent/instrumentation/jax-rs-annotations-1/src/main/java/datadog/trace/instrumentation/jaxrs1/JaxRsAnnotationsDecorator.java b/dd-java-agent/instrumentation/jax-rs-annotations-1/src/main/java/datadog/trace/instrumentation/jaxrs1/JaxRsAnnotationsDecorator.java
@@ -170,7 +170,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {
     boolean skipSlash = false;
     if (classPath != null) {
       if (!classPath.value().startsWith("/")) {
-        route.append("/");
+        route.append('/');
       }
       route.append(classPath.value());
       skipSlash = classPath.value().endsWith("/");
@@ -183,7 +183,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {
           path = path.length() == 1 ? "" : path.substring(1);
         }
       } else if (!path.startsWith("/")) {
-        route.append("/");
+        route.append('/');
       }
       route.append(path);
     }
diff --git a/dd-java-agent/instrumentation/jax-rs-annotations-2/src/main/java/datadog/trace/instrumentation/jaxrs2/JaxRsAnnotationsDecorator.java b/dd-java-agent/instrumentation/jax-rs-annotations-2/src/main/java/datadog/trace/instrumentation/jaxrs2/JaxRsAnnotationsDecorator.java
@@ -186,7 +186,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {
     boolean skipSlash = false;
     if (classPath != null) {
       if (!classPath.value().startsWith("/")) {
-        route.append("/");
+        route.append('/');
       }
       route.append(classPath.value());
       skipSlash = classPath.value().endsWith("/");
@@ -199,7 +199,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {
           path = path.length() == 1 ? "" : path.substring(1);
         }
       } else if (!path.startsWith("/")) {
-        route.append("/");
+        route.append('/');
       }
       route.append(path);
     }
diff --git a/dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java b/dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java
@@ -242,7 +242,7 @@ public String traceParent(AgentSpan span, int samplingPriority) {
     StringBuilder sb = new StringBuilder(55);
     sb.append("00-");
     sb.append(span.getTraceId().toHexString());
-    sb.append("-");
+    sb.append('-');
     sb.append(DDSpanId.toHexStringPadded(span.getSpanId()));
     sb.append(samplingPriority > 0 ? "-01" : "-00");
     return sb.toString();
diff --git a/dd-java-agent/instrumentation/maven-3.2.1/src/main/java/datadog/trace/instrumentation/maven3/MavenProjectConfigurator.java b/dd-java-agent/instrumentation/maven-3.2.1/src/main/java/datadog/trace/instrumentation/maven3/MavenProjectConfigurator.java
@@ -60,22 +60,22 @@ public void configureTracer(
       addedArgLine
           .append("-D")
           .append(e.getKey())
-          .append("=")
+          .append('=')
           .append(escapeForCommandLine(e.getValue()))
-          .append(" ");
+          .append(' ');
     }
 
     Integer ciVisibilityDebugPort = config.getCiVisibilityDebugPort();
     if (ciVisibilityDebugPort != null) {
       addedArgLine
           .append("-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=")
           .append(ciVisibilityDebugPort)
-          .append(" ");
+          .append(' ');
     }
 
     String additionalArgs = config.getCiVisibilityAdditionalChildProcessJvmArgs();
     if (additionalArgs != null) {
-      addedArgLine.append(additionalArgs).append(" ");
+      addedArgLine.append(additionalArgs).append(' ');
     }
 
     File agentJar = config.getCiVisibilityAgentJarFile();
diff --git a/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/main/java/datadog/trace/instrumentation/rabbitmq/amqp/RabbitDecorator.java b/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/main/java/datadog/trace/instrumentation/rabbitmq/amqp/RabbitDecorator.java
@@ -181,7 +181,7 @@ private String buildResourceName(
     final StringBuilder prefix =
         new StringBuilder(opName.length() + exchangeName.length() + routingKey.length() + 5)
             .append(opName)
-            .append(" ")
+            .append(' ')
             .append(exchangeName);
     if (Config.get().isRabbitIncludeRoutingKeyInResource()) {
       prefix.append(" -> ").append(routingKey);
diff --git a/dd-java-agent/instrumentation/testng/src/main/java/datadog/trace/instrumentation/testng/TestNGUtils.java b/dd-java-agent/instrumentation/testng/src/main/java/datadog/trace/instrumentation/testng/TestNGUtils.java
@@ -83,7 +83,7 @@ public static String getParameters(Object[] parameters) {
           .append(Strings.escapeToJson(String.valueOf(parameters[i])))
           .append("\"");
       if (i != parameters.length - 1) {
-        sb.append(",");
+        sb.append(',');
       }
     }
     sb.append("}}");
diff --git a/dd-java-agent/testing/src/test/java/locator/ClassInjectingTestInstrumentation.java b/dd-java-agent/testing/src/test/java/locator/ClassInjectingTestInstrumentation.java
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java b/dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/propagation/W3CHttpCodec.java b/dd-trace-core/src/main/java/datadog/trace/core/propagation/W3CHttpCodec.java
diff --git a/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/URIUtils.java b/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/URIUtils.java
diff --git a/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/java/lang/ProcessImplInstrumentationHelpers.java b/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/java/lang/ProcessImplInstrumentationHelpers.java
diff --git a/internal-api/src/main/java/datadog/trace/util/Strings.java b/internal-api/src/main/java/datadog/trace/util/Strings.java
diff --git a/internal-api/src/main/java/datadog/trace/util/TagsHelper.java b/internal-api/src/main/java/datadog/trace/util/TagsHelper.java
diff --git a/internal-api/src/test/java/datadog/trace/util/TagsHelperTest.java b/internal-api/src/test/java/datadog/trace/util/TagsHelperTest.java

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public String evaluate(CapturedContext context, LogProbe.LogStatus status) {`
`56`	`56`	`status.addError(new EvaluationError(ex.getExpr(), ex.getMessage()));`
`57`	`57`	`String msg =`
`58`	`58`	`ex instanceof RedactedException ? Redaction.REDACTED_VALUE : ex.getMessage();`
`59`		`- sb.append("{").append(msg).append("}");`
	`59`	`+ sb.append('{').append(msg).append('}');`
`60`	`60`	`}`
`61`	`61`	`if (!status.getErrors().isEmpty()) {`
`62`	`62`	`status.setLogTemplateErrors(true);`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public String concatTags() {`
`85`	`85`	`StringBuilder sb = new StringBuilder();`
`86`	`86`	`for (Tag tag : tags) {`
`87`	`87`	`if (sb.length() > 0) {`
`88`		`- sb.append(",");`
	`88`	`+ sb.append(',');`
`89`	`89`	`}`
`90`	`90`	`sb.append(tag);`
`91`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ private static int buildPayloadBatch(`
`61`	`61`	`List<String> payloads, int start, int count, StringBuilder sb) {`
`62`	`62`	`int totalSize = 0;`
`63`	`63`	`int elementCount = 0;`
`64`		`- sb.append("[");`
	`64`	`+ sb.append('[');`
`65`	`65`	`for (int i = start; i < start + count; i++) {`
`66`	`66`	`String jsonStr = payloads.get(i);`
`67`	`67`	`totalSize += jsonStr.length();`
`@@ -71,13 +71,13 @@ private static int buildPayloadBatch(`
`71`	`71`	`break;`
`72`	`72`	`}`
`73`	`73`	`sb.append(jsonStr);`
`74`		`- sb.append(",");`
	`74`	`+ sb.append(',');`
`75`	`75`	`elementCount++;`
`76`	`76`	`}`
`77`	`77`	`if (elementCount > 0) {`
`78`	`78`	`sb.delete(sb.lastIndexOf(","), sb.length());`
`79`	`79`	`}`
`80`		`- sb.append("]");`
	`80`	`+ sb.append(']');`
`81`	`81`	`return elementCount;`
`82`	`82`	`}`
`83`	`83`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ void collection() throws IOException {`
`55`	`55`	`StringBuilder sb = new StringBuilder();`
`56`	`56`	`for (int i = 0; i < 10; i++) {`
`57`	`57`	`if (i > 0) {`
`58`		`- sb.append(",");`
	`58`	`+ sb.append(',');`
`59`	`59`	`}`
`60`	`60`	`sb.append(String.format(CAPTURED_VALUE_SIMPLE_TEMPLATE, int.class.getTypeName(), i));`
`61`	`61`	`}`
`@@ -66,7 +66,7 @@ void collection() throws IOException {`
`66`	`66`	`sb = new StringBuilder();`
`67`	`67`	`for (int i = 0; i < 10; i++) {`
`68`	`68`	`if (i > 0) {`
`69`		`- sb.append(",");`
	`69`	`+ sb.append(',');`
`70`	`70`	`}`
`71`	`71`	`sb.append(`
`72`	`72`	`String.format(CAPTURED_VALUE_SIMPLE_TEMPLATE, String.class.getTypeName(), "foo" + i));`
Original file line number	Diff line number	Diff line change
`@@ -108,12 +108,12 @@ private void embedException(StringBuilder buf, Throwable t) {`
`108`	`108`	`if (t != null) {`
`109`	`109`	`buf.append(" [exception:");`
`110`	`110`	`buf.append(t.toString());`
`111`		`- buf.append(".");`
	`111`	`+ buf.append('.');`
`112`	`112`	`for (StackTraceElement element : t.getStackTrace()) {`
`113`	`113`	`buf.append(" at ");`
`114`	`114`	`buf.append(element.toString());`
`115`	`115`	`}`
`116`		`- buf.append("]");`
	`116`	`+ buf.append(']');`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,21 +66,21 @@ public void dispatch(List<Map<String, Object>> messages) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`if (batchCount + 1 > maxBatchRecords \|\| batchLength + bytes.length >= maxBatchBytes) {`
`69`		`- flush(batch.append("]"));`
	`69`	`+ flush(batch.append(']'));`
`70`	`70`	`batch = new StringBuilder("[");`
`71`	`71`	`batchCount = 0;`
`72`	`72`	`batchLength = 0;`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`if (batchCount != 0) {`
`76`		`- batch.append(",");`
	`76`	`+ batch.append(',');`
`77`	`77`	`}`
`78`	`78`	`batch.append(json);`
`79`	`79`	`batchCount += 1;`
`80`	`80`	`batchLength += bytes.length;`
`81`	`81`	`}`
`82`	`82`
`83`		`- flush(batch.append("]"));`
	`83`	`+ flush(batch.append(']'));`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`private void flush(StringBuilder batch) {`
Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ String cmdStartProfiling(Path file) throws IllegalStateException {`
`299`	`299`	`// wall profiling is enabled.`
`300`	`300`	`cmd.append(",wall=");`
`301`	`301`	`if (getWallCollapsing(configProvider)) {`
`302`		`- cmd.append("~");`
	`302`	`+ cmd.append('~');`
`303`	`303`	`}`
`304`	`304`	`cmd.append(getWallInterval(configProvider)).append('m');`
`305`	`305`	`if (getWallContextFilter(configProvider)) {`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ private static void summarize(StringBuilder buf, String prefix, AtomicLong stat)`
`206`	`206`	`long value = stat.get();`
`207`	`207`	`buf.append(prefix)`
`208`	`208`	`.append(String.format("%-12d", value >>> COUNT_SHIFT))`
`209`		`- .append(" ")`
	`209`	`+ .append(' ')`
`210`	`210`	`.append(String.format("%.1f", (value & NANOS_MASK) / 1_000_000.0))`
`211`	`211`	`.append(" ms\n");`
`212`	`212`	`}`
Original file line number	Diff line number	Diff line change
`@@ -159,12 +159,12 @@ private static String prettyPrint(final String prefix, final Reference ref) {`
`159`	`159`	`builder.append(Reference.prettyPrint(ref.flags));`
`160`	`160`	`builder.append(ref.className);`
`161`	`161`	`if (ref.superName != null) {`
`162`		`- builder.append(" extends<").append(ref.superName).append(">");`
	`162`	`+ builder.append(" extends<").append(ref.superName).append('>');`
`163`	`163`	`}`
`164`	`164`	`if (ref.interfaces.length > 0) {`
`165`	`165`	`builder.append(" implements ");`
`166`	`166`	`for (final String iface : ref.interfaces) {`
`167`		`- builder.append(" <").append(iface).append(">");`
	`167`	`+ builder.append(" <").append(iface).append('>');`
`168`	`168`	`}`
`169`	`169`	`}`
`170`	`170`	`for (final String source : ref.sources) {`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {`
`179`	`179`	`boolean skipSlash = false;`
`180`	`180`	`if (classPath != null) {`
`181`	`181`	`if (!classPath.value().startsWith("/")) {`
`182`		`- route.append("/");`
	`182`	`+ route.append('/');`
`183`	`183`	`}`
`184`	`184`	`route.append(classPath.value());`
`185`	`185`	`skipSlash = classPath.value().endsWith("/");`
`@@ -192,7 +192,7 @@ private String buildRoutePath(final Path classPath, final Path methodPath) {`
`192`	`192`	`path = path.length() == 1 ? "" : path.substring(1);`
`193`	`193`	`}`
`194`	`194`	`} else if (!path.startsWith("/")) {`
`195`		`- route.append("/");`
	`195`	`+ route.append('/');`
`196`	`196`	`}`
`197`	`197`	`route.append(path);`
`198`	`198`	`}`