Skip to content

Commit 5d7a98e

Browse files
committed
double interval
1 parent 295a700 commit 5d7a98e

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/ProbeStatusSink.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public ProbeStatusSink(Config config, String diagnosticsEndpoint, boolean useMul
5555
this.diagnosticUploader = diagnosticUploader;
5656
this.useMultiPart = useMultiPart;
5757
this.messageBuilder = new Builder(config);
58-
this.interval = Duration.ofSeconds(config.getDynamicInstrumentationDiagnosticsInterval());
58+
this.interval = Duration.ofMillis((long) (config.getDynamicInstrumentationDiagnosticsInterval() * 1000));
5959
this.batchSize = config.getDynamicInstrumentationUploadBatchSize();
6060
this.queue = new ArrayBlockingQueue<>(2 * this.batchSize);
6161
this.isInstrumentTheWorld = config.isDynamicInstrumentationInstrumentTheWorld();

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/sink/ProbeStatusSinkTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ class ProbeStatusSinkTest {
3333
private static final ProbeId PROBE_ID_NEW_VERSION = new ProbeId(PROBE_ID.getId(), 21);
3434
private static final ProbeId PROBE_ID2 = new ProbeId(UUID.randomUUID().toString(), 21);
3535
private static final String MESSAGE = "Foo";
36-
private static final int DIAGNOSTICS_INTERVAL = 60 * 60; // in seconds = 1h
36+
private static final double DIAGNOSTICS_INTERVAL = 60 * 60; // in seconds = 1h
3737
private static final Instant AFTER_INTERVAL_HAS_PASSED =
38-
Instant.now().plus(Duration.ofSeconds(DIAGNOSTICS_INTERVAL + 5));
38+
Instant.now().plus(Duration.ofSeconds((int) DIAGNOSTICS_INTERVAL + 5));
3939
private static final Instant BEFORE_INTERVAL_HAS_PASSED =
40-
Instant.now().plus(Duration.ofSeconds(DIAGNOSTICS_INTERVAL - 5));
40+
Instant.now().plus(Duration.ofSeconds((int) DIAGNOSTICS_INTERVAL - 5));
4141

4242
@Mock private Config config;
4343

internal-api/src/main/java/datadog/trace/api/Config.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ public static String getHostName() {
402402
private final int dynamicInstrumentationUploadFlushInterval;
403403
private final boolean dynamicInstrumentationClassFileDumpEnabled;
404404
private final int dynamicInstrumentationPollInterval;
405-
private final int dynamicInstrumentationDiagnosticsInterval;
405+
private final double dynamicInstrumentationDiagnosticsInterval;
406406
private final boolean dynamicInstrumentationMetricEnabled;
407407
private final String dynamicInstrumentationProbeFile;
408408
private final int dynamicInstrumentationUploadBatchSize;
@@ -1653,7 +1653,7 @@ PROFILING_DATADOG_PROFILER_ENABLED, isDatadogProfilerSafeInCurrentEnvironment())
16531653
configProvider.getInteger(
16541654
DYNAMIC_INSTRUMENTATION_POLL_INTERVAL, DEFAULT_DYNAMIC_INSTRUMENTATION_POLL_INTERVAL);
16551655
dynamicInstrumentationDiagnosticsInterval =
1656-
configProvider.getInteger(
1656+
configProvider.getDouble(
16571657
DYNAMIC_INSTRUMENTATION_DIAGNOSTICS_INTERVAL,
16581658
DEFAULT_DYNAMIC_INSTRUMENTATION_DIAGNOSTICS_INTERVAL);
16591659
dynamicInstrumentationMetricEnabled =
@@ -3222,7 +3222,7 @@ public int getDynamicInstrumentationPollInterval() {
32223222
return dynamicInstrumentationPollInterval;
32233223
}
32243224

3225-
public int getDynamicInstrumentationDiagnosticsInterval() {
3225+
public double getDynamicInstrumentationDiagnosticsInterval() {
32263226
return dynamicInstrumentationDiagnosticsInterval;
32273227
}
32283228

0 commit comments

Comments
 (0)