Skip to content

Commit b19e7ef

Browse files
committed
Fix tests
1 parent 952ab27 commit b19e7ef

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

telemetry/src/test/groovy/datadog/telemetry/metric/WafMetricPeriodicActionSpecification.groovy

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ class WafMetricPeriodicActionSpecification extends DDSpecification {
1111

1212
void 'push waf metrics into the telemetry service'() {
1313
setup:
14-
WafMetricCollector.get().wafInit('0.0.0', 'rules_ver_1')
15-
WafMetricCollector.get().wafUpdates('rules_ver_2')
16-
WafMetricCollector.get().wafUpdates('rules_ver_3')
14+
WafMetricCollector.get().wafInit('0.0.0', 'rules_ver_1', true)
15+
WafMetricCollector.get().wafUpdates('rules_ver_2', true)
16+
WafMetricCollector.get().wafUpdates('rules_ver_3', true)
1717

1818
when:
1919
periodicAction.doIteration(telemetryService)
@@ -23,26 +23,26 @@ class WafMetricPeriodicActionSpecification extends DDSpecification {
2323
metric.namespace == 'appsec' &&
2424
metric.metric == 'waf.init' &&
2525
metric.points[0][1] == 1 &&
26-
metric.tags == ['waf_version:0.0.0', 'event_rules_version:rules_ver_1']
26+
metric.tags == ['waf_version:0.0.0', 'event_rules_version:rules_ver_1', 'success:true']
2727
} )
2828
1 * telemetryService.addMetric( { Metric metric ->
2929
metric.namespace == 'appsec' &&
3030
metric.metric == 'waf.updates' &&
3131
metric.points[0][1] == 1 &&
32-
metric.tags == ['waf_version:0.0.0', 'event_rules_version:rules_ver_2']
32+
metric.tags == ['waf_version:0.0.0', 'event_rules_version:rules_ver_2', 'success:true']
3333
} )
3434
1 * telemetryService.addMetric( { Metric metric ->
3535
metric.namespace == 'appsec' &&
3636
metric.metric == 'waf.updates' &&
3737
metric.points[0][1] == 2 &&
38-
metric.tags == ['waf_version:0.0.0', 'event_rules_version:rules_ver_3']
38+
metric.tags == ['waf_version:0.0.0', 'event_rules_version:rules_ver_3', 'success:true']
3939
} )
4040
0 * _._
4141
}
4242

4343
void 'push waf request metrics and push into the telemetry'() {
4444
when:
45-
WafMetricCollector.get().wafInit('0.0.0', 'rules_ver_1')
45+
WafMetricCollector.get().wafInit('0.0.0', 'rules_ver_1', true)
4646
WafMetricCollector.get().wafRequest()
4747
WafMetricCollector.get().wafRequestTriggered()
4848
WafMetricCollector.get().wafRequest()
@@ -108,7 +108,7 @@ class WafMetricPeriodicActionSpecification extends DDSpecification {
108108
0 * _._
109109

110110
when: 'waf.updates happens'
111-
WafMetricCollector.get().wafUpdates('rules_ver_2')
111+
WafMetricCollector.get().wafUpdates('rules_ver_2', true)
112112
WafMetricCollector.get().wafRequest()
113113
WafMetricCollector.get().wafRequestTriggered()
114114
WafMetricCollector.get().wafRequestBlocked()

0 commit comments

Comments
 (0)