Skip to content

Commit b3ac124

Browse files
committed
clean up code a little
1 parent 3fd5db0 commit b3ac124

File tree

3 files changed

+36
-1
lines changed

3 files changed

+36
-1
lines changed

dd-java-agent/instrumentation/spring-webmvc-6.0/build.gradle

+3
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ dependencies {
3333
main_java17CompileOnly(group: 'org.springframework', name: 'spring-webmvc', version: '6.0.0')
3434
main_java17CompileOnly group: 'jakarta.servlet', name: 'jakarta.servlet-api', version: '5.0.0'
3535

36+
implementation project(':dd-java-agent:instrumentation:span-origin')
37+
main_java17Implementation project(':dd-java-agent:instrumentation:span-origin')
38+
3639
testImplementation(project(':dd-java-agent:testing')) {
3740
exclude(module: 'jetty-server') // incompatible servlet api
3841
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package datadog.trace.instrumentation.springweb6;
2+
3+
import static java.util.Arrays.asList;
4+
5+
import com.google.auto.service.AutoService;
6+
import datadog.trace.agent.tooling.InstrumenterModule;
7+
import datadog.trace.instrumentation.codeorigin.CodeOriginInstrumentation;
8+
import java.util.HashSet;
9+
import java.util.Set;
10+
11+
@AutoService(InstrumenterModule.class)
12+
public class SpringWebCodeOriginInstrumentation extends CodeOriginInstrumentation {
13+
private static final String WEB_BIND_ANNOTATION = "org.springframework.web.bind.annotation.";
14+
15+
public SpringWebCodeOriginInstrumentation() {
16+
super("spring-web-code-origin");
17+
}
18+
19+
@Override
20+
protected Set<String> getAnnotations() {
21+
return new HashSet<>(
22+
asList(
23+
WEB_BIND_ANNOTATION + "DeleteMapping",
24+
WEB_BIND_ANNOTATION + "GetMapping",
25+
WEB_BIND_ANNOTATION + "PatchMapping",
26+
WEB_BIND_ANNOTATION + "PostMapping",
27+
WEB_BIND_ANNOTATION + "PutMapping",
28+
WEB_BIND_ANNOTATION + "RequestMapping"));
29+
}
30+
}

dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/AgentTestRunner.groovy

+3-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import datadog.trace.api.IdGenerationStrategy
3030
import datadog.trace.api.StatsDClient
3131
import datadog.trace.api.TraceConfig
3232
import datadog.trace.api.WellKnownTags
33+
import datadog.trace.api.config.DebuggerConfig
3334
import datadog.trace.api.config.GeneralConfig
3435
import datadog.trace.api.config.TracerConfig
3536
import datadog.trace.api.gateway.RequestContext
@@ -84,6 +85,7 @@ import static datadog.communication.http.OkHttpUtils.buildHttpClient
8485
import static datadog.trace.api.ConfigDefaults.DEFAULT_AGENT_HOST
8586
import static datadog.trace.api.ConfigDefaults.DEFAULT_AGENT_TIMEOUT
8687
import static datadog.trace.api.ConfigDefaults.DEFAULT_TRACE_AGENT_PORT
88+
import static datadog.trace.api.config.DebuggerConfig.*
8789
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_ENABLED
8890
import static datadog.trace.api.config.DebuggerConfig.DYNAMIC_INSTRUMENTATION_VERIFY_BYTECODE
8991
import static datadog.trace.api.config.TraceInstrumentationConfig.CODE_ORIGIN_FOR_SPANS_ENABLED
@@ -307,7 +309,7 @@ abstract class AgentTestRunner extends DDSpecification implements AgentBuilder.L
307309

308310
def codeOriginSetup() {
309311
injectSysConfig(CODE_ORIGIN_FOR_SPANS_ENABLED, "true", true)
310-
injectSysConfig(DYNAMIC_INSTRUMENTATION_ENABLED, "false", true)
312+
injectSysConfig(DYNAMIC_INSTRUMENTATION_ENABLED, "true", true)
311313
injectSysConfig(DYNAMIC_INSTRUMENTATION_VERIFY_BYTECODE, "false", true)
312314

313315
def configuration = Configuration.builder()

0 commit comments

Comments
 (0)