Skip to content

Commit ba3f346

Browse files
jpbempelamarziali
authored andcommitted
Fix In-Product when config is empty (#8679)
should not stop the product with empty config
1 parent c7ec7ce commit ba3f346

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DefaultProductConfigUpdater.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,12 @@ private static void startOrStopFeature(
7070
LOGGER.debug("Feature {} is explicitly disabled", booleanKey);
7171
return;
7272
}
73-
if (currentStatus != null && currentStatus) {
74-
start.run();
75-
} else {
76-
stop.run();
73+
if (currentStatus != null) {
74+
if (currentStatus) {
75+
start.run();
76+
} else {
77+
stop.run();
78+
}
7779
}
7880
}
7981
}

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/DefaultProductConfigUpdaterTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ public void enableDisable() {
2424
assertTrue(productConfigUpdater.isExceptionReplayEnabled());
2525
assertTrue(productConfigUpdater.isCodeOriginEnabled());
2626
assertTrue(productConfigUpdater.isDistributedDebuggerEnabled());
27+
productConfigUpdater.updateConfig(null, null, null, null);
28+
assertTrue(productConfigUpdater.isDynamicInstrumentationEnabled());
29+
assertTrue(productConfigUpdater.isExceptionReplayEnabled());
30+
assertTrue(productConfigUpdater.isCodeOriginEnabled());
31+
assertTrue(productConfigUpdater.isDistributedDebuggerEnabled());
2732
productConfigUpdater.updateConfig(false, false, false, false);
2833
assertFalse(productConfigUpdater.isDynamicInstrumentationEnabled());
2934
assertFalse(productConfigUpdater.isExceptionReplayEnabled());

0 commit comments

Comments
 (0)