Skip to content

Commit bbd40f0

Browse files
authored
Fix flaky test on TomcatServlet3TestAsync (#7550)
1 parent 4abf841 commit bbd40f0

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

dd-java-agent/instrumentation/servlet/request-3/src/test/groovy/TomcatServlet3Test.groovy

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,8 @@ abstract class TomcatServlet3Test extends AbstractServlet3Test<Tomcat, Context>
199199

200200
and:
201201
assertTraces(count) {
202+
Set<Tuple2<String, String>> loggedSpanIds = accessLogValue.loggedIds.toSet()
203+
assert loggedSpanIds.size() == count
202204
(1..count).eachWithIndex { val, i ->
203205
trace(spanCount(SUCCESS)) {
204206
sortSpansByStart()
@@ -212,9 +214,8 @@ abstract class TomcatServlet3Test extends AbstractServlet3Test<Tomcat, Context>
212214
}
213215
}
214216

215-
def (String traceId, String spanId) = accessLogValue.loggedIds[i]
216-
assert trace(i).get(0).traceId.toString() == traceId
217-
assert trace(i).get(0).spanId.toString() == spanId
217+
def ids = new Tuple2(trace(i).get(0).localRootSpan.traceId.toString(), trace(i).get(0).localRootSpan.spanId.toString())
218+
assert ids in loggedSpanIds
218219
}
219220
}
220221

@@ -250,8 +251,8 @@ abstract class TomcatServlet3Test extends AbstractServlet3Test<Tomcat, Context>
250251
}
251252

252253
def (String traceId, String spanId) = accessLogValue.loggedIds[0]
253-
assert trace(0).get(0).traceId.toString() == traceId
254-
assert trace(0).get(0).spanId.toString() == spanId
254+
assert trace(0).get(0).localRootSpan.traceId.toString() == traceId
255+
assert trace(0).get(0).localRootSpan.spanId.toString() == spanId
255256
}
256257

257258
where:

0 commit comments

Comments
 (0)