Skip to content

Commit c1a7978

Browse files
author
Cecile Terpin
committed
Fix text
1 parent 3fefc0d commit c1a7978

File tree

1 file changed

+22
-18
lines changed

1 file changed

+22
-18
lines changed

dd-trace-core/src/test/groovy/datadog/trace/core/traceinterceptor/LatencyTraceInterceptorTest.groovy

+22-18
Original file line numberDiff line numberDiff line change
@@ -13,34 +13,38 @@ class LatencyTraceInterceptorTest extends DDCoreSpecification {
1313

1414
def "test set sampling priority according to latency"() {
1515
setup:
16-
def writer = new ListWriter()
17-
def props = new Properties()
18-
props.setProperty("trace.partial.flush.enabled", partialFlushEnabled)
19-
props.setProperty("trace.latency.interceptor.value", latencyThreshold)
2016

21-
def tracer = tracerBuilder().withProperties(props).writer(writer).build()
17+
injectSysConfig("trace.partial.flush.enabled", partialFlushEnabled)
18+
injectSysConfig("trace.latency.interceptor.value", latencyThreshold)
19+
20+
when:
21+
def writer = new ListWriter()
22+
def tracer = tracerBuilder().writer(writer).build()
2223

23-
def spanSetup = tracer.buildSpan("test","my_operation_name").withTag(tagname, true).start()
24-
sleep(duration)
24+
def spanSetup = tracer.buildSpan("test","my_operation_name").withTag(priorityTag, true).start()
25+
sleep(minDuration)
2526
spanSetup.finish()
2627

27-
expect:
28+
then:
2829
def trace = writer.firstTrace()
2930
trace.size() == 1
3031
def span = trace[0]
31-
3232
span.context().getSamplingPriority() == expected
3333

34+
cleanup:
3435
tracer.close()
36+
3537
where:
36-
partialFlushEnabled | latencyThreshold | tagname | duration | expected
37-
"true" | "102" | DDTags.MANUAL_KEEP | 100 | 2
38-
"true" | "102" | DDTags.MANUAL_DROP | 100 | -1
39-
"true" | "102" | DDTags.MANUAL_KEEP | 105 | 2
40-
"true" | "102" | DDTags.MANUAL_DROP | 105 | -1
41-
// "false" | "102" | DDTags.MANUAL_KEEP | 100 | 2
42-
// "false" | "102" | DDTags.MANUAL_DROP | 100 | -1
43-
// "false" | "102" | DDTags.MANUAL_KEEP | 105 | 2
44-
// "false" | "102" | DDTags.MANUAL_DROP | 105 | 2
38+
partialFlushEnabled | latencyThreshold | priorityTag | minDuration | expected
39+
"true" | "200" | DDTags.MANUAL_KEEP | 10 | 2
40+
"true" | "200" | DDTags.MANUAL_DROP | 10 | -1
41+
"true" | "200" | DDTags.MANUAL_KEEP | 300 | 2
42+
"true" | "200" | DDTags.MANUAL_DROP | 300 | -1
43+
"false" | "200" | DDTags.MANUAL_KEEP | 10 | 2
44+
"false" | "200" | DDTags.MANUAL_DROP | 10 | -1
45+
"false" | "200" | DDTags.MANUAL_KEEP | 300 | 2
46+
"false" | "200" | DDTags.MANUAL_DROP | 300 | 2
4547
}
48+
49+
4650
}

0 commit comments

Comments
 (0)