set OL if detected

Signed-off-by: Maciej Obuchowski <[email protected]>

Author: mobuchowski

dd-java-agent/instrumentation/spark/src/main/java/datadog/trace/instrumentation/spark/AbstractDatadogSparkListener.java

@@ -33,9 +33,12 @@
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.Properties;
 import java.util.UUID;
+import java.util.function.Consumer;
+import java.util.stream.Collectors;
 import org.apache.spark.ExceptionFailure;
 import org.apache.spark.SparkConf;
 import org.apache.spark.TaskFailedReason;
@@ -74,6 +77,7 @@ public abstract class AbstractDatadogSparkListener extends SparkListener {
   private final int MAX_COLLECTION_SIZE = 5000;
   private final int MAX_ACCUMULATOR_SIZE = 50000;
   private final String RUNTIME_TAGS_PREFIX = "spark.datadog.tags.";
+  private static final String AGENT_OL_ENDPOINT = "openlineage/api/v1/lineage";
 
   private final SparkConf sparkConf;
   private final String sparkVersion;
@@ -123,6 +127,7 @@ public abstract class AbstractDatadogSparkListener extends SparkListener {
   private long availableExecutorTime = 0;
 
   private volatile boolean applicationEnded = false;
+  private SparkListener openLineageSparkListener = null;
 
   public AbstractDatadogSparkListener(SparkConf sparkConf, String appId, String sparkVersion) {
     tracer = AgentTracer.get();
@@ -151,8 +156,50 @@ public AbstractDatadogSparkListener(SparkConf sparkConf, String appId, String sp
                     finishApplication(System.currentTimeMillis(), null, 0, null);
                   }
                 }));
+    initApplicationSpanIfNotInitialized();
+    loadOlSparkListener();
+  }
+
+  static void setupSparkConf(SparkConf sparkConf) {
+    sparkConf.set("spark.openlineage.transport.type", "composite");
+    sparkConf.set("spark.openlineage.transport.continueOnFailure", "true");
+    sparkConf.set("spark.openlineage.transport.transports.agent.type", "http");
+    sparkConf.set("spark.openlineage.transport.transports.agent.url", getAgentHttpUrl());
+    sparkConf.set("spark.openlineage.transport.transports.agent.endpoint", AGENT_OL_ENDPOINT);
+    sparkConf.set("spark.openlineage.transport.transports.agent.compression", "gzip");
+  }
 
-    log.info("Created datadog spark listener: {}", this.getClass().getSimpleName());
+  void setupTrace(SparkConf sc) {
+    sc.set(
+        "spark.openlineage.run.tags",
+        "_dd.trace_id:"
+            + applicationSpan.context().getTraceId().toString()
+            + ";_dd.intake.emit_spans:false");
+  }
+
+  void loadOlSparkListener() {
+    String className = "io.openlineage.spark.agent.OpenLineageSparkListener";
+    Optional<Class> clazz = loadClass(className);
+    if (!clazz.isPresent()) {
+      log.info("OpenLineage integration is not present on the classpath");
+      return;
+    }
+    try {
+      setupSparkConf(sparkConf);
+      sparkConf.set(
+          "spark.openlineage.run.tags",
+          "_dd.trace_id:"
+              + applicationSpan.context().getTraceId().toString()
+              + ";_dd.ol_intake.emit_spans:false");
+
+      openLineageSparkListener =
+          (SparkListener)
+              clazz.get().getDeclaredConstructor(SparkConf.class).newInstance(sparkConf);
+      log.info(
+          "Created OL spark listener: {}", openLineageSparkListener.getClass().getSimpleName());
+    } catch (Exception e) {
+      log.warn("Failed to instantiate OL Spark Listener: {}", e.toString());
+    }
   }
 
   /** Resource name of the spark job. Provide an implementation based on a specific scala version */
@@ -176,6 +223,8 @@ public AbstractDatadogSparkListener(SparkConf sparkConf, String appId, String sp
   @Override
   public synchronized void onApplicationStart(SparkListenerApplicationStart applicationStart) {
     this.applicationStart = applicationStart;
+    initApplicationSpanIfNotInitialized();
+    notifyOl(this.openLineageSparkListener::onApplicationStart, applicationStart);
   }
 
   private void initApplicationSpanIfNotInitialized() {
@@ -233,6 +282,7 @@ public void onApplicationEnd(SparkListenerApplicationEnd applicationEnd) {
     log.info(
         "Received spark application end event, finish trace on this event: {}",
         finishTraceOnApplicationEnd);
+    notifyOl(this.openLineageSparkListener::onApplicationEnd, applicationEnd);
 
     if (finishTraceOnApplicationEnd) {
       finishApplication(applicationEnd.time(), null, 0, null);
@@ -426,6 +476,7 @@ public synchronized void onJobStart(SparkListenerJobStart jobStart) {
       stageToJob.put(stageId, jobStart.jobId());
     }
     jobSpans.put(jobStart.jobId(), jobSpan);
+    notifyOl(this.openLineageSparkListener::onJobStart, jobStart);
   }
 
   @Override
@@ -456,6 +507,7 @@ public synchronized void onJobEnd(SparkListenerJobEnd jobEnd) {
     if (metrics != null) {
       metrics.setSpanMetrics(jobSpan);
     }
+    notifyOl(this.openLineageSparkListener::onJobEnd, jobEnd);
 
     jobSpan.finish(jobEnd.time() * 1000);
   }
@@ -624,6 +676,8 @@ public void onTaskEnd(SparkListenerTaskEnd taskEnd) {
 
     Properties props = stageProperties.get(stageSpanKey);
     sendTaskSpan(stageSpan, taskEnd, props);
+
+    notifyOl(this.openLineageSparkListener::onTaskEnd, taskEnd);
   }
 
   private void sendTaskSpan(
@@ -705,6 +759,15 @@ public void onOtherEvent(SparkListenerEvent event) {
     updateAdaptiveSQLPlan(event);
   }
 
+  private <T extends SparkListenerEvent> void notifyOl(Consumer<T> ol, T event) {
+    if (this.openLineageSparkListener != null) {
+      log.debug("Notifying with event `{}`", event.getClass().getCanonicalName());
+      ol.accept(event);
+    } else {
+      log.debug("OpenLineageSparkListener is null");
+    }
+  }
+
   private static final Class<?> adaptiveExecutionUpdateClass;
   private static final MethodHandle adaptiveExecutionIdMethod;
   private static final MethodHandle adaptiveSparkPlanMethod;
@@ -765,6 +828,7 @@ private synchronized void onSQLExecutionEnd(SparkListenerSQLExecutionEnd sqlEnd)
       if (metrics != null) {
         metrics.setSpanMetrics(span);
       }
+      notifyOl(this.openLineageSparkListener::onOtherEvent, sqlEnd);
 
       span.finish(sqlEnd.time() * 1000);
     }
@@ -923,7 +987,7 @@ private void setDataJobsSamplingPriority(AgentSpan span) {
 
   private AgentTracer.SpanBuilder buildSparkSpan(String spanName, Properties properties) {
     AgentTracer.SpanBuilder builder =
-        tracer.buildSpan(spanName).withSpanType("spark").withTag("app_id", appId);
+        tracer.buildSpan("spark", spanName).withSpanType("spark").withTag("app_id", appId);
 
     if (databricksServiceName != null) {
       builder.withServiceName(databricksServiceName);
@@ -1260,9 +1324,71 @@ private static String getDatabricksRunName(SparkConf conf) {
     return null;
   }
 
+  private static String getAgentHttpUrl() {
+    StringBuilder sb =
+        new StringBuilder("http://")
+            .append(Config.get().getAgentHost())
+            .append(":")
+            .append(Config.get().getAgentPort());
+    return sb.toString();
+  }
+
   @SuppressForbidden // called at most once per spark application
   private static String removeUuidFromEndOfString(String input) {
     return input.replaceAll(
         "_[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$", "");
   }
+
+  private Optional<Class> loadClass(String className) {
+    Class clazz = null;
+    List<ClassLoader> availableClassloaders =
+        Thread.getAllStackTraces().keySet().stream()
+            .map(Thread::getContextClassLoader)
+            .filter(Objects::nonNull)
+            .collect(Collectors.toList());
+    try {
+      clazz = Class.forName(className);
+    } catch (Exception e) {
+      log.debug("Failed to load {} via Class.forName: {}", className, e.toString());
+      for (ClassLoader classLoader : availableClassloaders) {
+        try {
+          clazz = classLoader.loadClass(className);
+          log.debug("Loaded {} via classLoader: {}", className, classLoader);
+          break;
+        } catch (Exception ex) {
+          log.debug(
+              "Failed to load {} via loadClass via ClassLoader {} - {}",
+              className,
+              classLoader,
+              ex.toString());
+        }
+        try {
+          clazz = classLoader.getParent().loadClass(className);
+          log.debug(
+              "Loaded {} via parent classLoader: {} for CL {}",
+              className,
+              classLoader.getParent(),
+              classLoader);
+          break;
+        } catch (Exception ex) {
+          log.debug(
+              "Failed to load {} via loadClass via parent ClassLoader {} - {}",
+              className,
+              classLoader.getParent(),
+              ex.toString());
+        }
+      }
+    }
+    if (clazz == null) {
+      try {
+        clazz = ClassLoader.getSystemClassLoader().loadClass(className);
+        log.debug(
+            "Loaded {} via system classLoader: {}", className, ClassLoader.getSystemClassLoader());
+      } catch (Exception ex) {
+        log.debug(
+            "Failed to load {} via loadClass via SystemClassLoader {}", className, ex.toString());
+      }
+    }
+    return Optional.ofNullable(clazz);
+  }
 }

dd-java-agent/instrumentation/spark/src/main/java/datadog/trace/instrumentation/spark/AbstractSparkInstrumentation.java

@@ -10,10 +10,15 @@
 import datadog.trace.agent.tooling.InstrumenterModule;
 import net.bytebuddy.asm.Advice;
 import org.apache.spark.deploy.SparkSubmitArguments;
+import org.apache.spark.scheduler.SparkListenerInterface;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public abstract class AbstractSparkInstrumentation extends InstrumenterModule.Tracing
     implements Instrumenter.ForKnownTypes, Instrumenter.HasMethodAdvice {
 
+  private static final Logger log = LoggerFactory.getLogger(AbstractSparkInstrumentation.class);
+
   public AbstractSparkInstrumentation() {
     super("spark", "apache-spark");
   }
@@ -28,7 +33,8 @@ public String[] knownMatchingTypes() {
     return new String[] {
       "org.apache.spark.SparkContext",
       "org.apache.spark.deploy.SparkSubmit",
-      "org.apache.spark.deploy.yarn.ApplicationMaster"
+      "org.apache.spark.deploy.yarn.ApplicationMaster",
+      "org.apache.spark.scheduler.LiveListenerBus",
     };
   }
 
@@ -55,6 +61,14 @@ public void methodAdvice(MethodTransformer transformer) {
             .and(named("finish"))
             .and(isDeclaredBy(named("org.apache.spark.deploy.yarn.ApplicationMaster"))),
         AbstractSparkInstrumentation.class.getName() + "$YarnFinishAdvice");
+
+    // LiveListenerBus class is used when running in a YARN cluster
+    transformer.applyAdvice(
+        isMethod()
+            .and(named("addToSharedQueue"))
+            .and(takesArgument(0, named("org.apache.spark.scheduler.SparkListenerInterface")))
+            .and(isDeclaredBy(named("org.apache.spark.scheduler.LiveListenerBus"))),
+        AbstractSparkInstrumentation.class.getName() + "$LiveListenerBusAdvice");
   }
 
   public static class PrepareSubmitEnvAdvice {
@@ -100,4 +114,18 @@ public static void enter(@Advice.Argument(1) int exitCode, @Advice.Argument(2) S
       }
     }
   }
+
+  public static class LiveListenerBusAdvice {
+    @Advice.OnMethodEnter(suppress = Throwable.class, skipOn = Advice.OnNonDefaultValue.class)
+    public static boolean enter(@Advice.Argument(0) SparkListenerInterface listener) {
+      // Skip instantiating OpenLineage listener - we will inject it later with custom config
+      if (listener == null || listener.getClass().getCanonicalName() == null) {
+        return false;
+      }
+      return listener
+          .getClass()
+          .getCanonicalName()
+          .equals("io.openlineage.spark.agent.OpenLineageSparkListener");
+    }
+  }
 }