Skip to content

Commit de6b0c4

Browse files
committed
rename a constant
stop walking the stack at the first hit since that's all we use anyway.
1 parent fa4af98 commit de6b0c4

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationAcceptor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
public interface ConfigurationAcceptor {
77
enum Source {
88
REMOTE_CONFIG,
9-
SPAN_DEBUG,
9+
CODE_ORIGIN,
1010
EXCEPTION
1111
}
1212

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/codeorigin/CodeOriginProbeManager.java

+7-13
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.datadog.debugger.codeorigin;
22

3-
import static com.datadog.debugger.agent.ConfigurationAcceptor.Source.SPAN_DEBUG;
3+
import static com.datadog.debugger.agent.ConfigurationAcceptor.Source.CODE_ORIGIN;
44

55
import com.datadog.debugger.agent.ConfigurationUpdater;
66
import com.datadog.debugger.exception.Fingerprinter;
@@ -16,11 +16,9 @@
1616
import java.util.Collection;
1717
import java.util.Collections;
1818
import java.util.HashMap;
19-
import java.util.List;
2019
import java.util.Map;
2120
import java.util.UUID;
2221
import java.util.concurrent.ConcurrentHashMap;
23-
import java.util.stream.Collectors;
2422
import org.slf4j.Logger;
2523
import org.slf4j.LoggerFactory;
2624

@@ -96,7 +94,7 @@ public String createProbeForFrame(String signature) {
9694
public String installProbe(CodeOriginProbe probe) {
9795
CodeOriginProbe installed = probes.putIfAbsent(probe.getId(), probe);
9896
if (installed == null) {
99-
taskScheduler.execute(() -> configurationUpdater.accept(SPAN_DEBUG, getProbes()));
97+
taskScheduler.execute(() -> configurationUpdater.accept(CODE_ORIGIN, getProbes()));
10098
return probe.getId();
10199
}
102100
return installed.getId();
@@ -108,14 +106,10 @@ public boolean isAlreadyInstrumented(String fingerprint) {
108106

109107
private StackTraceElement findPlaceInStack() {
110108
return StackWalkerFactory.INSTANCE.walk(
111-
stream -> {
112-
List<StackTraceElement> list = stream.collect(Collectors.toList());
113-
list =
114-
list.stream()
115-
.filter(element -> !classNameFiltering.isExcluded(element.getClassName()))
116-
.collect(Collectors.toList());
117-
118-
return list.stream().findFirst().orElse(null);
119-
});
109+
stream ->
110+
stream
111+
.filter(element -> !classNameFiltering.isExcluded(element.getClassName()))
112+
.findFirst()
113+
.orElse(null));
120114
}
121115
}

0 commit comments

Comments
 (0)