Simplify activateSpan API to not include async propagation flag (#8557)

These remaining cases were no-op spans which are already not propagated

Author: mcculls

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaActorCellInstrumentation.java

@@ -81,7 +81,7 @@ public static void enter(
         return;
       }
       // Create an active scope with a noop span, and clean all the way to the previous scope
-      activateSpan(noopSpan(), false);
+      activateSpan(noopSpan());
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaMailboxInstrumentation.java

@@ -75,7 +75,7 @@ public static void enter() {
         return;
       }
       // Create an active scope with a noop span, and clean all the way to the previous scope
-      activateSpan(noopSpan(), false);
+      activateSpan(noopSpan());
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/pekko-concurrent/src/main/java/datadog/trace/instrumentation/pekko/concurrent/PekkoActorCellInstrumentation.java

@@ -81,7 +81,7 @@ public static void enter(
         return;
       }
       // Create an active scope with a noop span, and clean all the way to the previous scope
-      activateSpan(noopSpan(), false);
+      activateSpan(noopSpan());
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-java-agent/instrumentation/pekko-concurrent/src/main/java/datadog/trace/instrumentation/pekko/concurrent/PekkoMailboxInstrumentation.java

@@ -76,7 +76,7 @@ public static void enter() {
         return;
       }
       // Create an active scope with a noop span, and clean all the way to the previous scope
-      activateSpan(noopSpan(), false);
+      activateSpan(noopSpan());
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

@@ -906,18 +906,14 @@ public AgentSpan startSpan(
         .start();
   }
 
-  public AgentScope activateSpan(final AgentSpan span) {
-    return activateSpan(span, DEFAULT_ASYNC_PROPAGATING);
-  }
-
   @Override
-  public AgentScope activateSpan(AgentSpan span, boolean isAsyncPropagating) {
-    return scopeManager.activate(span, ScopeSource.INSTRUMENTATION, isAsyncPropagating);
+  public AgentScope activateSpan(AgentSpan span) {
+    return scopeManager.activate(span, ScopeSource.INSTRUMENTATION, DEFAULT_ASYNC_PROPAGATING);
   }
 
   @Override
   public AgentScope activateManualSpan(final AgentSpan span) {
-    return scopeManager.activate(span, ScopeSource.MANUAL);
+    return scopeManager.activate(span, ScopeSource.MANUAL /* inherit async propagation flag */);
   }
 
   @Override

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java

@@ -1,7 +1,5 @@
 package datadog.trace.bootstrap.instrumentation.api;
 
-import static datadog.trace.api.ConfigDefaults.DEFAULT_ASYNC_PROPAGATING;
-
 import datadog.trace.api.ConfigDefaults;
 import datadog.trace.api.DDTraceId;
 import datadog.trace.api.EndpointCheckpointer;
@@ -86,11 +84,7 @@ public static AgentSpan startSpan(
   }
 
   public static AgentScope activateSpan(final AgentSpan span) {
-    return get().activateSpan(span, DEFAULT_ASYNC_PROPAGATING);
-  }
-
-  public static AgentScope activateSpan(final AgentSpan span, final boolean isAsyncPropagating) {
-    return get().activateSpan(span, isAsyncPropagating);
+    return get().activateSpan(span);
   }
 
   /**
@@ -339,7 +333,7 @@ AgentSpan startSpan(
         long startTimeMicros);
 
     /** Activate a span from inside auto-instrumentation. */
-    AgentScope activateSpan(AgentSpan span, boolean isAsyncPropagating);
+    AgentScope activateSpan(AgentSpan span);
 
     /** Activate a span from outside auto-instrumentation, i.e. a manual or custom span. */
     AgentScope activateManualSpan(AgentSpan span);
@@ -480,7 +474,7 @@ public AgentSpan startSpan(
     }
 
     @Override
-    public AgentScope activateSpan(final AgentSpan span, final boolean isAsyncPropagating) {
+    public AgentScope activateSpan(final AgentSpan span) {
       return NoopScope.INSTANCE;
     }