Skip to content

Commit f0fe5bd

Browse files
committed
Use the correct setting name
1 parent 7984628 commit f0fe5bd

File tree

7 files changed

+15
-16
lines changed

7 files changed

+15
-16
lines changed

dd-java-agent/instrumentation/spring-boot/src/test/groovy/SpringBootApplicationTest.groovy

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@ import datadog.trace.api.ProcessTags
33
import static datadog.trace.agent.test.utils.TraceUtils.runUnderTrace
44

55
import datadog.trace.agent.test.AgentTestRunner
6-
import datadog.trace.api.Config
76
import org.springframework.beans.factory.InitializingBean
87
import org.springframework.boot.SpringApplication
98

10-
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED
9+
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED
1110

1211
class SpringBootApplicationTest extends AgentTestRunner {
1312
@Override
1413
protected void configurePreAgent() {
1514
super.configurePreAgent()
16-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
15+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
1716
}
1817

1918
static class BeanWhoTraces implements InitializingBean {

dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public final class GeneralConfig {
2929
@Deprecated // Use dd.tags instead
3030
public static final String GLOBAL_TAGS = "trace.global.tags";
3131

32-
public static final String EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED =
33-
"experimental.collect.tags.enabled";
32+
public static final String EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED =
33+
"experimental.propagate.process.tags.enabled";
3434

3535
public static final String LOG_LEVEL = "log.level";
3636
public static final String TRACE_DEBUG = "trace.debug";

dd-trace-core/src/test/groovy/datadog/trace/common/metrics/SerializingMetricWriterTest.groovy

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import org.msgpack.core.MessageUnpacker
1111
import java.nio.ByteBuffer
1212
import java.util.concurrent.atomic.AtomicLongArray
1313

14-
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED
14+
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED
1515
import static java.util.concurrent.TimeUnit.MILLISECONDS
1616
import static java.util.concurrent.TimeUnit.SECONDS
1717

@@ -20,7 +20,7 @@ class SerializingMetricWriterTest extends DDSpecification {
2020
def "should produce correct message #iterationIndex with process tags enabled #withProcessTags" () {
2121
setup:
2222
if (withProcessTags) {
23-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
23+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
2424
}
2525
ProcessTags.reset()
2626
long startTime = MILLISECONDS.toNanos(System.currentTimeMillis())

dd-trace-core/src/test/groovy/datadog/trace/common/writer/ddagent/TraceMapperV04PayloadTest.groovy

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import org.msgpack.core.MessageUnpacker
2121
import java.nio.ByteBuffer
2222
import java.nio.channels.WritableByteChannel
2323

24-
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED
24+
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED
2525
import static datadog.trace.bootstrap.instrumentation.api.InstrumentationTags.DD_MEASURED
2626
import static datadog.trace.common.writer.TraceGenerator.generateRandomTraces
2727
import static org.junit.jupiter.api.Assertions.assertEquals
@@ -177,7 +177,7 @@ class TraceMapperV04PayloadTest extends DDSpecification {
177177

178178
void 'test process tags serialization'() {
179179
setup:
180-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
180+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
181181
ProcessTags.reset()
182182
assertNotNull(ProcessTags.tagsForSerialization)
183183
def spans = (1..2).collect {

dd-trace-core/src/test/groovy/datadog/trace/common/writer/ddagent/TraceMapperV05PayloadTest.groovy

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import java.nio.ByteBuffer
2323
import java.nio.channels.WritableByteChannel
2424
import java.util.concurrent.atomic.AtomicInteger
2525

26-
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED
26+
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED
2727
import static datadog.trace.bootstrap.instrumentation.api.InstrumentationTags.DD_MEASURED
2828
import static datadog.trace.common.writer.TraceGenerator.generateRandomTraces
2929
import static org.junit.Assert.assertEquals
@@ -135,7 +135,7 @@ class TraceMapperV05PayloadTest extends DDSpecification {
135135

136136
void 'test process tags serialization'() {
137137
setup:
138-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
138+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
139139
ProcessTags.reset()
140140
assertNotNull(ProcessTags.tagsForSerialization)
141141
def spans = (1..2).collect {

internal-api/src/main/java/datadog/trace/api/Config.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
848848
removeIntegrationServiceNamesEnabled =
849849
configProvider.getBoolean(TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED, false);
850850
experimentalCollectProcessTagsEnabled =
851-
configProvider.getBoolean(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, false);
851+
configProvider.getBoolean(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, false);
852852

853853
peerServiceMapping = configProvider.getMergedMap(TRACE_PEER_SERVICE_MAPPING);
854854

internal-api/src/test/groovy/datadog/trace/api/ProcessTagsForkedTest.groovy

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import datadog.trace.test.util.DDSpecification
55

66
import java.nio.file.Paths
77

8-
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED
8+
import static datadog.trace.api.config.GeneralConfig.EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED
99

1010
class ProcessTagsForkedTest extends DDSpecification {
1111

@@ -22,7 +22,7 @@ class ProcessTagsForkedTest extends DDSpecification {
2222

2323
def 'should load default tags for jar #jar and main class #cls'() {
2424
given:
25-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
25+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
2626
CapturedEnvironment.useFixedProcessInfo(new CapturedEnvironment.ProcessInfo(cls, jar))
2727
ProcessTags.reset()
2828
def tags = ProcessTags.getTagsForSerialization()
@@ -38,7 +38,7 @@ class ProcessTagsForkedTest extends DDSpecification {
3838

3939
def 'should load default tags jboss (mode #mode)'() {
4040
setup:
41-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
41+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
4242
if (jbossHome != null) {
4343
System.setProperty("jboss.home.dir", jbossHome)
4444
}
@@ -76,7 +76,7 @@ class ProcessTagsForkedTest extends DDSpecification {
7676

7777
def 'should lazily recalculate when a tag is added'() {
7878
setup:
79-
injectSysConfig(EXPERIMENTAL_COLLECT_PROCESS_TAGS_ENABLED, "true")
79+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
8080
ProcessTags.reset()
8181
when:
8282
def processTags = ProcessTags.tagsForSerialization

0 commit comments

Comments
 (0)