Skip to content

Commit 1871f28

Browse files
authored
ci: update regression check rules for release tags (#13141)
Fix for #13135 which incorrectly was looking at the branch name and not the tag name. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 698db4a commit 1871f28

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.gitlab/benchmarks/microbenchmarks.yml

+6-2
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,12 @@ benchmarks-pr-comment:
184184
check-big-regressions:
185185
stage: report
186186
rules:
187-
# Run and warn on release branches, but don't fail the pipeline
188-
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+$/
187+
# Run and warn on releases, but don't fail the pipeline
188+
# v2.10.0
189+
# v2.10.1
190+
# v2.10.0rc0
191+
# v2.10.0rc5
192+
- if: $CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$/
189193
allow_failure: true
190194
- allow_failure: false
191195
when: always

0 commit comments

Comments
 (0)