ruff

Author: valentijnscholten

unittests/tools/test_tenable_parser.py

@@ -1,3 +1,4 @@
+from pathlib import Path
 from dojo.models import Engagement, Finding, Product, Test
 from dojo.tools.tenable.parser import TenableParser
 from unittests.dojo_test_case import DojoTestCase, get_unit_tests_scans_path
@@ -11,7 +12,7 @@ def create_test(self):
         return test
 
     def test_parse_some_findings_nessus_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln.xml", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln.xml").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -28,7 +29,7 @@ def test_parse_some_findings_nessus_legacy(self):
 
     def test_parse_some_findings_csv_nessus_legacy(self):
         """Test one report provided by a user"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -58,7 +59,7 @@ def test_parse_some_findings_csv_nessus_legacy(self):
 
     def test_parse_some_findings_csv2_nessus_legacy(self):
         """Test that use default columns of Nessus Pro 8.13.1 (#257)"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-default.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-default.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -80,7 +81,7 @@ def test_parse_some_findings_csv2_nessus_legacy(self):
 
     def test_parse_some_findings_csv2_all_nessus_legacy(self):
         """Test that use a report with all columns of Nessus Pro 8.13.1 (#257)"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -102,7 +103,7 @@ def test_parse_some_findings_csv2_all_nessus_legacy(self):
 
     def test_parse_findings_all_nessus(self):
         """Test that use a report with all columns selected in generate CSV Report 2025-04-14"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus-template.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus-template.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -128,19 +129,19 @@ def test_parse_findings_all_nessus(self):
 
     def test_parse_some_findings_csv_bytes_nessus_legacy(self):
         """This tests is designed to test the parser with different read modes"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
                 for endpoint in finding.unsaved_endpoints:
                     endpoint.clean()
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
                 for endpoint in finding.unsaved_endpoints:
                     endpoint.clean()
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv", "rb") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_many_vuln2-all.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -149,7 +150,7 @@ def test_parse_some_findings_csv_bytes_nessus_legacy(self):
 
     def test_parse_some_findings_samples_nessus_legacy(self):
         """Test that come from samples repo"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_v_unknown.xml", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_v_unknown.xml").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -180,7 +181,7 @@ def test_parse_some_findings_samples_nessus_legacy(self):
 
     def test_parse_some_findings_with_cvssv3_nessus_legacy(self):
         """Test with cvssv3"""
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_with_cvssv3.nessus", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_with_cvssv3.nessus").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -195,7 +196,7 @@ def test_parse_some_findings_with_cvssv3_nessus_legacy(self):
             self.assertEqual("CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N", finding.cvssv3)
 
     def test_parse_many_findings_xml_nessus_was_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_many_vuln.xml", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_many_vuln.xml").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -213,7 +214,7 @@ def test_parse_many_findings_xml_nessus_was_legacy(self):
             # self.assertEqual(79, finding.cwe)
 
     def test_parse_one_findings_xml_nessus_was_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_one_vuln.xml", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_one_vuln.xml").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -228,7 +229,7 @@ def test_parse_one_findings_xml_nessus_was_legacy(self):
             self.assertEqual("Cross-Site Scripting (XSS)", finding.title)
 
     def test_parse_no_findings_xml_nessus_was_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_no_vuln.xml", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_no_vuln.xml").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -237,7 +238,7 @@ def test_parse_no_findings_xml_nessus_was_legacy(self):
             self.assertEqual(0, len(findings))
 
     def test_parse_many_findings_csv_nessus_was_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_many_vuln.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_many_vuln.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -256,7 +257,7 @@ def test_parse_many_findings_csv_nessus_was_legacy(self):
             self.assertEqual(0, finding.cwe)
 
     def test_parse_one_findings_csv_nessus_was_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_one_vuln.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_one_vuln.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -272,13 +273,13 @@ def test_parse_one_findings_csv_nessus_was_legacy(self):
             self.assertEqual("http", finding.unsaved_endpoints[0].protocol)
 
     def test_parse_no_findings_csv_nessus_was_legacy(self):
-        with open(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_no_vuln.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus_was") / "nessus_was_no_vuln.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             self.assertEqual(0, len(findings))
 
     def test_parse_many_tenable_vulns(self):
-        with open(get_unit_tests_scans_path("tenable") / "tenable_many_vuln.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable") / "tenable_many_vuln.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -298,7 +299,7 @@ def test_parse_many_tenable_vulns(self):
                 self.assertEqual("CVE-2023-32233", vulnerability_id)
 
     def test_parse_issue_6992(self):
-        with open(get_unit_tests_scans_path("tenable/nessus") / "issue_6992.nessus", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "issue_6992.nessus").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -308,7 +309,7 @@ def test_parse_issue_6992(self):
             self.assertEqual("High", findings[0].severity)
 
     def test_parse_nessus_new(self):
-        with open(get_unit_tests_scans_path("tenable/nessus") / "nessus_new.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable/nessus") / "nessus_new.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             self.assertEqual(99, len(findings))
@@ -319,7 +320,7 @@ def test_parse_nessus_new(self):
             self.assertEqual("3.1", finding.cvssv3_score)
 
     def test_parse_issue_9612(self):
-        with open(get_unit_tests_scans_path("tenable") / "issue_9612.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable") / "issue_9612.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -329,7 +330,7 @@ def test_parse_issue_9612(self):
             self.assertEqual("Critical", findings[0].severity)
 
     def test_parse_issue_11102(self):
-        with open(get_unit_tests_scans_path("tenable") / "issue_11102.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable") / "issue_11102.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings:
@@ -339,7 +340,7 @@ def test_parse_issue_11102(self):
             self.assertEqual("Reconfigure the affected application if possible to avoid use of medium strength ciphers.", findings[0].mitigation)
 
     def test_parse_issue_11127(self):
-        with open(get_unit_tests_scans_path("tenable") / "issue_11102.csv", encoding="utf-8") as testfile:
+        with Path(get_unit_tests_scans_path("tenable") / "issue_11102.csv").open(encoding="utf-8") as testfile:
             parser = TenableParser()
             findings = parser.get_findings(testfile, self.create_test())
             for finding in findings: