Added catchErrors option for the useAsyncCallbackHook;

Author: DigitalBrainJS

lib/use-async-effect.js

@@ -158,6 +158,7 @@ const argsToPromiseMap = new Map();
  * @param {number} [options.queueSize=0]
  * @param {boolean} [options.scopeArg= false]
  * @param {boolean} [options.states= true]
+ * @param {boolean} [options.catchErrors= true]
  * @returns {UseAsyncCallbackDecoratedFn}
  */
 const useAsyncCallback = (generator, options) => {
@@ -180,7 +181,8 @@ const useAsyncCallback = (generator, options) => {
         threads,
         queueSize = -1,
         scopeArg= false,
-        states= false
+        states= false,
+        catchErrors= false
     } = options && Array.isArray(options) ? {deps: options} : options || {};
 
     if (threads === undefined) {
@@ -234,7 +236,7 @@ const useAsyncCallback = (generator, options) => {
         if (threads || queueSize !== -1) {
             let started;
 
-            const promise = new CPromise(resolve => {
+            let promise = new CPromise(resolve => {
                 const start= ()=> {
                     current.pending++;
 
@@ -261,7 +263,7 @@ const useAsyncCallback = (generator, options) => {
                 start();
             }).weight(0)
                 .then(resolveGenerator)
-                .finally((value, isRejected) => {
+                [catchErrors? 'done': 'finally']((value, isRejected) => {
                     started && current.pending--;
                     removeElement(promises, promise);
                     combine && argsToPromiseMap.delete(promise);
@@ -287,7 +289,7 @@ const useAsyncCallback = (generator, options) => {
             return promise;
         }
 
-        const promise = resolveGenerator().finally(() => {
+        const promise = resolveGenerator()[catchErrors? 'done' : 'finally'](() => {
             removeElement(promises, promise);
             combine && argsToPromiseMap.delete(promise);
         }).weight(0).aggregate();
@@ -296,7 +298,6 @@ const useAsyncCallback = (generator, options) => {
 
         if (combine) {
             argsToPromiseMap.set(promise, args);
-            return CPromise.resolve(promise);
         }
 
         return promise;

test/src/index.js

@@ -570,4 +570,37 @@ describe("useAsyncCallback", function () {
           document.getElementById('root')
         );
     });
+
+    it("should not throw if catchErrors option is set and internal async task was rejected", function (done) {
+        let counter = 0;
+
+        function TestComponent() {
+            const fn1 = useAsyncCallback(function* () {
+                throw Error('test');
+            }, {catchErrors: true});
+
+            const fn2 = useAsyncCallback(function* () {
+                throw Error('test');
+            }, {catchErrors: false});
+
+            Promise.all([
+                fn1().catch(()=>{
+                    assert.fail('should not throw');
+                }),
+                fn2().then(()=>{
+                    assert.fail('should throw')
+                }, (err)=>{
+                    assert.ok(err instanceof Error);
+                    assert.strictEqual(err.message, 'test');
+                })
+            ]).then(()=> done(), done);
+
+            return <div>Test</div>
+        }
+
+        ReactDOM.render(
+          <TestComponent/>,
+          document.getElementById('root')
+        );
+    });
 });