Skip to content

Commit 6995688

Browse files
authored
Remove extra ; from generated code (dotnet#114)
* Added sequential grouping of columns * reverted the file * Set up CI with Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * removed extra ; from generated code * removed file * fix unit tests
1 parent 6ed9d0a commit 6995688

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/mlnet.Test/CodeGenTests.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public void TrainerGeneratorBasicNamedParameterTest()
2525
Pipeline pipeline = new Pipeline(new PipelineNode[] { node });
2626
CodeGenerator codeGenerator = new CodeGenerator(pipeline, (null, null));
2727
var actual = codeGenerator.GenerateTrainerAndUsings();
28-
string expected = "LightGbm(learningRate:0.1f,numLeaves:1,labelColumn:\"Label\",featureColumn:\"Features\");";
28+
string expected = "LightGbm(learningRate:0.1f,numLeaves:1,labelColumn:\"Label\",featureColumn:\"Features\")";
2929
Assert.AreEqual(expected, actual.Item1);
3030
Assert.IsNull(actual.Item2);
3131
}
@@ -45,7 +45,7 @@ public void TrainerGeneratorBasicAdvancedParameterTest()
4545
Pipeline pipeline = new Pipeline(new PipelineNode[] { node });
4646
CodeGenerator codeGenerator = new CodeGenerator(pipeline, (null, null));
4747
var actual = codeGenerator.GenerateTrainerAndUsings();
48-
string expectedTrainer = "LightGbm(new Options(){LearningRate=0.1f,NumLeaves=1,UseSoftmax=true,LabelColumn=\"Label\",FeatureColumn=\"Features\"});";
48+
string expectedTrainer = "LightGbm(new Options(){LearningRate=0.1f,NumLeaves=1,UseSoftmax=true,LabelColumn=\"Label\",FeatureColumn=\"Features\"})";
4949
string expectedUsing = "using Microsoft.ML.LightGBM;\r\n";
5050
Assert.AreEqual(expectedTrainer, actual.Item1);
5151
Assert.AreEqual(expectedUsing, actual.Item2);
@@ -163,7 +163,7 @@ public void TrainerComplexParameterTest()
163163
Pipeline pipeline = new Pipeline(new PipelineNode[] { node });
164164
CodeGenerator codeGenerator = new CodeGenerator(pipeline, (null, null));
165165
var actual = codeGenerator.GenerateTrainerAndUsings();
166-
string expectedTrainer = "LightGbm(new Options(){Booster=new TreeBooster(){},LabelColumn=\"Label\",FeatureColumn=\"Features\"});";
166+
string expectedTrainer = "LightGbm(new Options(){Booster=new TreeBooster(){},LabelColumn=\"Label\",FeatureColumn=\"Features\"})";
167167
var expectedUsings = "using Microsoft.ML.LightGBM;\r\n";
168168
Assert.AreEqual(expectedTrainer, actual.Item1);
169169
Assert.AreEqual(expectedUsings, actual.Item2);

src/mlnet/CodeGenerator/TrainerGeneratorBase.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public string GenerateTrainer()
133133
{
134134
sb.Append(AppendArguments(arguments, ":"));
135135
}
136-
sb.Append(");");
136+
sb.Append(")");
137137
return sb.ToString();
138138
}
139139

0 commit comments

Comments
 (0)