Skip to content

Commit 2d38bc9

Browse files
committed
Internals: renamed recently added ImGuiInputReadFlags to ImGuiInputFlags. (Amend 8b8a61b)
1 parent 6ab5fd1 commit 2d38bc9

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

imgui.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -7735,14 +7735,14 @@ int ImGui::CalcTypematicRepeatAmount(float t0, float t1, float repeat_delay, flo
77357735
return count;
77367736
}
77377737

7738-
void ImGui::GetTypematicRepeatRate(ImGuiInputReadFlags flags, float* repeat_delay, float* repeat_rate)
7738+
void ImGui::GetTypematicRepeatRate(ImGuiInputFlags flags, float* repeat_delay, float* repeat_rate)
77397739
{
77407740
ImGuiContext& g = *GImGui;
7741-
switch (flags & ImGuiInputReadFlags_RepeatRateMask_)
7741+
switch (flags & ImGuiInputFlags_RepeatRateMask_)
77427742
{
7743-
case ImGuiInputReadFlags_RepeatRateNavMove: *repeat_delay = g.IO.KeyRepeatDelay * 0.72f; *repeat_rate = g.IO.KeyRepeatRate * 0.80f; return;
7744-
case ImGuiInputReadFlags_RepeatRateNavTweak: *repeat_delay = g.IO.KeyRepeatDelay * 0.72f; *repeat_rate = g.IO.KeyRepeatRate * 0.30f; return;
7745-
case ImGuiInputReadFlags_RepeatRateDefault: default: *repeat_delay = g.IO.KeyRepeatDelay * 1.00f; *repeat_rate = g.IO.KeyRepeatRate * 1.00f; return;
7743+
case ImGuiInputFlags_RepeatRateNavMove: *repeat_delay = g.IO.KeyRepeatDelay * 0.72f; *repeat_rate = g.IO.KeyRepeatRate * 0.80f; return;
7744+
case ImGuiInputFlags_RepeatRateNavTweak: *repeat_delay = g.IO.KeyRepeatDelay * 0.72f; *repeat_rate = g.IO.KeyRepeatRate * 0.30f; return;
7745+
case ImGuiInputFlags_RepeatRateDefault: default: *repeat_delay = g.IO.KeyRepeatDelay * 1.00f; *repeat_rate = g.IO.KeyRepeatRate * 1.00f; return;
77467746
}
77477747
}
77487748

@@ -7776,20 +7776,20 @@ bool ImGui::IsKeyDown(ImGuiKey key)
77767776

77777777
bool ImGui::IsKeyPressed(ImGuiKey key, bool repeat)
77787778
{
7779-
return IsKeyPressedEx(key, repeat ? ImGuiInputReadFlags_Repeat : ImGuiInputReadFlags_None);
7779+
return IsKeyPressedEx(key, repeat ? ImGuiInputFlags_Repeat : ImGuiInputFlags_None);
77807780
}
77817781

77827782
// Important: unlike legacy IsKeyPressed(ImGuiKey, bool repeat=true) which DEFAULT to repeat, this requires EXPLICIT repeat.
77837783
// [Internal] 2022/07: Do not call this directly! It is a temporary entry point which we will soon replace with an overload for IsKeyPressed() when we introduce key ownership.
7784-
bool ImGui::IsKeyPressedEx(ImGuiKey key, ImGuiInputReadFlags flags)
7784+
bool ImGui::IsKeyPressedEx(ImGuiKey key, ImGuiInputFlags flags)
77857785
{
77867786
const ImGuiKeyData* key_data = GetKeyData(key);
77877787
const float t = key_data->DownDuration;
77887788
if (t < 0.0f)
77897789
return false;
77907790

77917791
bool pressed = (t == 0.0f);
7792-
if (!pressed && ((flags & ImGuiInputReadFlags_Repeat) != 0))
7792+
if (!pressed && ((flags & ImGuiInputFlags_Repeat) != 0))
77937793
{
77947794
float repeat_delay, repeat_rate;
77957795
GetTypematicRepeatRate(flags, &repeat_delay, &repeat_rate);
@@ -10225,7 +10225,7 @@ float ImGui::GetNavTweakPressedAmount(ImGuiAxis axis)
1022510225
{
1022610226
ImGuiContext& g = *GImGui;
1022710227
float repeat_delay, repeat_rate;
10228-
GetTypematicRepeatRate(ImGuiInputReadFlags_RepeatRateNavTweak, &repeat_delay, &repeat_rate);
10228+
GetTypematicRepeatRate(ImGuiInputFlags_RepeatRateNavTweak, &repeat_delay, &repeat_rate);
1022910229

1023010230
ImGuiKey key_less, key_more;
1023110231
if (g.NavInputSource == ImGuiInputSource_Gamepad)
@@ -10444,7 +10444,7 @@ void ImGui::NavUpdateCreateMoveRequest()
1044410444
g.NavMoveScrollFlags = ImGuiScrollFlags_None;
1044510445
if (window && !g.NavWindowingTarget && !(window->Flags & ImGuiWindowFlags_NoNavInputs))
1044610446
{
10447-
const ImGuiInputReadFlags repeat_mode = ImGuiInputReadFlags_Repeat | ImGuiInputReadFlags_RepeatRateNavMove;
10447+
const ImGuiInputFlags repeat_mode = ImGuiInputFlags_Repeat | ImGuiInputFlags_RepeatRateNavMove;
1044810448
if (!IsActiveIdUsingNavDir(ImGuiDir_Left) && (IsKeyPressedEx(ImGuiKey_GamepadDpadLeft, repeat_mode) || IsKeyPressedEx(ImGuiKey_LeftArrow, repeat_mode))) { g.NavMoveDir = ImGuiDir_Left; }
1044910449
if (!IsActiveIdUsingNavDir(ImGuiDir_Right) && (IsKeyPressedEx(ImGuiKey_GamepadDpadRight, repeat_mode) || IsKeyPressedEx(ImGuiKey_RightArrow, repeat_mode))) { g.NavMoveDir = ImGuiDir_Right; }
1045010450
if (!IsActiveIdUsingNavDir(ImGuiDir_Up) && (IsKeyPressedEx(ImGuiKey_GamepadDpadUp, repeat_mode) || IsKeyPressedEx(ImGuiKey_UpArrow, repeat_mode))) { g.NavMoveDir = ImGuiDir_Up; }

imgui_internal.h

+10-10
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ struct ImGuiWindowSettings; // Storage for a window .ini settings (we ke
148148
typedef int ImGuiLayoutType; // -> enum ImGuiLayoutType_ // Enum: Horizontal or vertical
149149
typedef int ImGuiActivateFlags; // -> enum ImGuiActivateFlags_ // Flags: for navigation/focus function (will be for ActivateItem() later)
150150
typedef int ImGuiDebugLogFlags; // -> enum ImGuiDebugLogFlags_ // Flags: for ShowDebugLogWindow(), g.DebugLogFlags
151-
typedef int ImGuiInputReadFlags; // -> enum ImGuiInputReadFlags_ // Flags: for IsKeyPressedEx()
151+
typedef int ImGuiInputFlags; // -> enum ImGuiInputFlags_ // Flags: for IsKeyPressedEx()
152152
typedef int ImGuiItemFlags; // -> enum ImGuiItemFlags_ // Flags: for PushItemFlag()
153153
typedef int ImGuiItemStatusFlags; // -> enum ImGuiItemStatusFlags_ // Flags: for DC.LastItemStatusFlags
154154
typedef int ImGuiOldColumnFlags; // -> enum ImGuiOldColumnFlags_ // Flags: for BeginColumns()
@@ -1243,15 +1243,15 @@ struct ImGuiInputEvent
12431243

12441244
// Flags for IsKeyPressedEx(). In upcoming feature this will be used more (and IsKeyPressedEx() renamed)
12451245
// Don't mistake with ImGuiInputTextFlags! (for ImGui::InputText() function)
1246-
enum ImGuiInputReadFlags_
1246+
enum ImGuiInputFlags_
12471247
{
12481248
// Flags for IsKeyPressedEx()
1249-
ImGuiInputReadFlags_None = 0,
1250-
ImGuiInputReadFlags_Repeat = 1 << 0, // Return true on successive repeats. Default for legacy IsKeyPressed(). NOT Default for legacy IsMouseClicked(). MUST BE == 1.
1251-
ImGuiInputReadFlags_RepeatRateDefault = 1 << 1, // Repeat rate: Regular (default)
1252-
ImGuiInputReadFlags_RepeatRateNavMove = 1 << 2, // Repeat rate: Fast
1253-
ImGuiInputReadFlags_RepeatRateNavTweak = 1 << 3, // Repeat rate: Faster
1254-
ImGuiInputReadFlags_RepeatRateMask_ = ImGuiInputReadFlags_RepeatRateDefault | ImGuiInputReadFlags_RepeatRateNavMove | ImGuiInputReadFlags_RepeatRateNavTweak,
1249+
ImGuiInputFlags_None = 0,
1250+
ImGuiInputFlags_Repeat = 1 << 0, // Return true on successive repeats. Default for legacy IsKeyPressed(). NOT Default for legacy IsMouseClicked(). MUST BE == 1.
1251+
ImGuiInputFlags_RepeatRateDefault = 1 << 1, // Repeat rate: Regular (default)
1252+
ImGuiInputFlags_RepeatRateNavMove = 1 << 2, // Repeat rate: Fast
1253+
ImGuiInputFlags_RepeatRateNavTweak = 1 << 3, // Repeat rate: Faster
1254+
ImGuiInputFlags_RepeatRateMask_ = ImGuiInputFlags_RepeatRateDefault | ImGuiInputFlags_RepeatRateNavMove | ImGuiInputFlags_RepeatRateNavTweak,
12551255
};
12561256

12571257
//-----------------------------------------------------------------------------
@@ -2712,8 +2712,8 @@ namespace ImGui
27122712
IMGUI_API ImVec2 GetKeyVector2d(ImGuiKey key_left, ImGuiKey key_right, ImGuiKey key_up, ImGuiKey key_down);
27132713
IMGUI_API float GetNavTweakPressedAmount(ImGuiAxis axis);
27142714
IMGUI_API int CalcTypematicRepeatAmount(float t0, float t1, float repeat_delay, float repeat_rate);
2715-
IMGUI_API void GetTypematicRepeatRate(ImGuiInputReadFlags flags, float* repeat_delay, float* repeat_rate);
2716-
IMGUI_API bool IsKeyPressedEx(ImGuiKey key, ImGuiInputReadFlags flags = 0);
2715+
IMGUI_API void GetTypematicRepeatRate(ImGuiInputFlags flags, float* repeat_delay, float* repeat_rate);
2716+
IMGUI_API bool IsKeyPressedEx(ImGuiKey key, ImGuiInputFlags flags = 0);
27172717
#ifndef IMGUI_DISABLE_OBSOLETE_KEYIO
27182718
inline bool IsKeyPressedMap(ImGuiKey key, bool repeat = true) { IM_ASSERT(IsNamedKey(key)); return IsKeyPressed(key, repeat); } // [removed in 1.87]
27192719
#endif

0 commit comments

Comments
 (0)