Skip to content

Commit 58f5092

Browse files
committed
Docking: fixed settings load issue when mouse wheeling. (ocornut#4310)
1 parent 6bd447c commit 58f5092

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

docs/CHANGELOG.txt

+5
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,11 @@ Other changes:
9999
Note that Linux/Mac still have inconsistent support for multi-viewports. If you want to help see https://github.com/ocornut/imgui/issues/2117.
100100

101101

102+
Docking+Viewports Branch:
103+
104+
- Docking: fixed settings load issue when mouse wheeling. (#4310)
105+
106+
102107
-----------------------------------------------------------------------
103108
VERSION 1.84.1 (Released 2021-08-20)
104109
-----------------------------------------------------------------------

imgui.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -13111,7 +13111,10 @@ void ImGui::DockContextProcessUndockNode(ImGuiContext* ctx, ImGuiDockNode* node)
1311113111
DockNodeMoveWindows(new_node, node);
1311213112
DockSettingsRenameNodeReferences(node->ID, new_node->ID);
1311313113
for (int n = 0; n < new_node->Windows.Size; n++)
13114+
{
13115+
new_node->Windows[n]->Flags &= ~ImGuiWindowFlags_ChildWindow;
1311413116
UpdateWindowParentAndRootLinks(new_node->Windows[n], new_node->Windows[n]->Flags, NULL);
13117+
}
1311513118
node = new_node;
1311613119
}
1311713120
else
@@ -13293,7 +13296,8 @@ static void ImGui::DockNodeRemoveWindow(ImGuiDockNode* node, ImGuiWindow* window
1329313296
window->DockNode = NULL;
1329413297
window->DockIsActive = window->DockTabWantClose = false;
1329513298
window->DockId = save_dock_id;
13296-
UpdateWindowParentAndRootLinks(window, window->Flags & ~ImGuiWindowFlags_ChildWindow, NULL); // Update immediately
13299+
window->Flags &= ~ImGuiWindowFlags_ChildWindow;
13300+
UpdateWindowParentAndRootLinks(window, window->Flags, NULL); // Update immediately
1329713301

1329813302
// Remove window
1329913303
bool erased = false;

0 commit comments

Comments
 (0)