Skip to content

Commit 37b133e

Browse files
barnsoncompnerd
authored andcommitted
Add checkboxes per SDK for redist MSMs.
Also disable modify button in ARP.
1 parent 4539d4a commit 37b133e

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

platforms/Windows/bundle/installer.wxs

+7
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
Name="!(loc.BundleName) $(ProductVersion)"
44
Version="$(ProductVersion)"
55
Manufacturer="!(loc.ManufacturerName)"
6+
DisableModify="yes"
67
Compressed="$(IsBundleCompressed)"
78
UpgradeCode="$(BundleUpgradeCode)">
89

@@ -31,8 +32,11 @@
3132
<Variable Name="OptionsInstallIde" bal:Overridable="yes" Persisted="yes" Value="1" />
3233
<Variable Name="OptionsInstallRtl" bal:Overridable="yes" Persisted="yes" Value="1" />
3334
<Variable Name="OptionsInstallSdkX86" bal:Overridable="yes" Persisted="yes" Value="1" />
35+
<Variable Name="OptionsInstallRedistX86" bal:Overridable="yes" Persisted="yes" Value="1" />
3436
<Variable Name="OptionsInstallSdkAMD64" bal:Overridable="yes" Persisted="yes" Value="1" />
37+
<Variable Name="OptionsInstallRedistAMD64" bal:Overridable="yes" Persisted="yes" Value="1" />
3538
<Variable Name="OptionsInstallSdkArm64" bal:Overridable="yes" Persisted="yes" Value="1" />
39+
<Variable Name="OptionsInstallRedistArm64" bal:Overridable="yes" Persisted="yes" Value="1" />
3640

3741
<!--
3842
For the online bundle, we need to provide a download URL for each package and its .cabs.
@@ -95,6 +99,7 @@
9599
InstallCondition="OptionsInstallSdkX86"
96100
DownloadUrl="$(BaseReleaseDownloadUrl)/{2}">
97101
<MsiProperty Name="INSTALLROOT" Value="[InstallRoot]" />
102+
<MsiProperty Name="INSTALLREDIST" Value="[OptionsInstallRedistX86]" />
98103
</MsiPackage>
99104
<?endif?>
100105

@@ -103,6 +108,7 @@
103108
InstallCondition="OptionsInstallSdkAMD64"
104109
DownloadUrl="$(BaseReleaseDownloadUrl)/{2}">
105110
<MsiProperty Name="INSTALLROOT" Value="[InstallRoot]" />
111+
<MsiProperty Name="INSTALLREDIST" Value="[OptionsInstallRedistAMD64]" />
106112
</MsiPackage>
107113

108114
<?if $(INCLUDE_ARM64_SDK) == true ?>
@@ -111,6 +117,7 @@
111117
InstallCondition="OptionsInstallSdkArm64"
112118
DownloadUrl="$(BaseReleaseDownloadUrl)/{2}">
113119
<MsiProperty Name="INSTALLROOT" Value="[InstallRoot]" />
120+
<MsiProperty Name="INSTALLREDIST" Value="[OptionsInstallRedistArm64]" />
114121
</MsiPackage>
115122
<?endif?>
116123
</Chain>

platforms/Windows/bundle/theme.xml

+6-3
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,12 @@
6262
<Checkbox Name="OptionsInstallDbg" X="185" Y="152" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Dbg_ProductName)</Checkbox>
6363
<Checkbox Name="OptionsInstallIde" X="185" Y="170" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Ide_ProductName)</Checkbox>
6464
<Checkbox Name="OptionsInstallRtl" X="185" Y="188" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Rtl_ProductName)</Checkbox>
65-
<!-- <Checkbox Name="OptionsInstallSdkX86" X="185" Y="206" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Sdk_ProductName_x86)</Checkbox> -->
66-
<Checkbox Name="OptionsInstallSdkAMD64" X="185" Y="224" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Sdk_ProductName_amd64)</Checkbox>
67-
<!-- <Checkbox Name="OptionsInstallSdkArm64" X="185" Y="242" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Sdk_ProductName_arm64)</Checkbox> -->
65+
<Checkbox Name="OptionsInstallSdkAMD64" X="185" Y="206" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Sdk_ProductName_amd64)</Checkbox>
66+
<Checkbox Name="OptionsInstallRedistAMD64" X="203" Y="224" Width="-11" Height="17" TabStop="yes" FontId="3" EnableCondition="OptionsInstallSdkAMD64">#(loc.Redist_amd64)</Checkbox>
67+
<Checkbox Name="OptionsInstallSdkX86" X="185" Y="242" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Sdk_ProductName_x86)</Checkbox>
68+
<Checkbox Name="OptionsInstallRedistX86" X="203" Y="260" Width="-11" Height="17" TabStop="yes" FontId="3" EnableCondition="OptionsInstallSdkX86">#(loc.Redist_x86)</Checkbox>
69+
<Checkbox Name="OptionsInstallSdkArm64" X="185" Y="278" Width="-11" Height="17" TabStop="yes" FontId="3">#(loc.Sdk_ProductName_arm64)</Checkbox>
70+
<Checkbox Name="OptionsInstallRedistArm64" X="203" Y="296" Width="-11" Height="17" TabStop="yes" FontId="3" EnableCondition="OptionsInstallSdkArm64">#(loc.Redist_arm64)</Checkbox>
6871

6972
<Button Name="OptionsOkButton" X="-91" Y="-11" Width="75" Height="23" TabStop="yes" FontId="0">
7073
<Text>#(loc.OptionsOkButton)</Text>

platforms/Windows/sdk/sdk.wxs

+1-1
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@
472472
</Component>
473473
</ComponentGroup>
474474

475-
<Component Id="rtl.msm" Directory="RedistVersion">
475+
<Component Id="rtl.msm" Directory="RedistVersion" Condition="INSTALLREDIST">
476476
<File Source="!(bindpath.rtlmsm)\rtl.$(ProductArchitecture).msm" />
477477
</Component>
478478

platforms/Windows/shared/swift.en-us.wxl

+3
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
<String Id="ManufacturerName" Value="swift.org" />
1818

1919
<String Id="OptionsFeaturesLabel" Value="Choose the features you want to install" />
20+
<String Id="Redist_arm64" Value="Swift Windows Redistributable (ARM64)" />
21+
<String Id="Redist_amd64" Value="Swift Windows Redistributable (AMD64)" />
22+
<String Id="Redist_x86" Value="Swift Windows Redistributable (x86)" />
2023

2124
<String Id="Caption" Value="[WixBundleName] Setup" />
2225
<String Id="Title" Value="[WixBundleName]" />

0 commit comments

Comments
 (0)