Skip to content

Commit ff78001

Browse files
[Test][Time profiler] Fix test time checking
This test sometimes triggers failures during build testing. For instance, see: https://lab.llvm.org/buildbot/#/builders/52/builds/10161, details: https://lab.llvm.org/buildbot/#/builders/52/builds/10161/steps/5/logs/FAIL__Clang__check-time-trace-sections_cpp . AFAICT the time between driver calling and checking its time tracker output is not guaranteed to be stable and small: ``` > head -2 check-time-trace-sections.cpp // RUN: %clangxx -S -ftime-trace -ftime-trace-granularity=0 -o %T/check-time-trace-sections %s // RUN: cat %T/check-time-trace-sections.json | %python %S/check-time-trace-sections.py > clang -S -ftime-trace -ftime-trace-granularity=0 -o /tmp/check check-time-trace-sections.cpp > cat /tmp/check.json | python check-time-trace-sections.py > sleep 10 > cat /tmp/check.json | python check-time-trace-sections.py 'beginningOfTime' should represent the absolute time when the process has started > ``` The attribute `beginningOfTime` was introduced here: https://reviews.llvm.org/D78030 One can change "10 sec" value to something longer, but I believe it's enough just to check that `beginningOfTime` exists and is not later than current time. Differential Revision: https://reviews.llvm.org/D108625
1 parent 0115262 commit ff78001

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

clang/test/Driver/check-time-trace-sections.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@ def is_before(range1, range2):
2020
beginning_of_time = log_contents["beginningOfTime"] / 1000000
2121
seconds_since_epoch = time.time()
2222

23-
# Make sure that the 'beginningOfTime' is not earlier than 10 seconds ago
24-
# and not later than now.
25-
if beginning_of_time > seconds_since_epoch or \
26-
seconds_since_epoch - beginning_of_time > 10:
23+
# Make sure that the 'beginningOfTime' is not later than now.
24+
if beginning_of_time > seconds_since_epoch:
2725
sys.exit("'beginningOfTime' should represent the absolute time when the "
2826
"process has started")
2927

0 commit comments

Comments
 (0)