Add RuboCop

Author: diogot

.rubocop.yml

@@ -0,0 +1,11 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Exclude:
+    - 'Carthage/**/*'
+
+Metrics/ParameterLists:
+  Max: 8
+
+Metrics/MethodLength:
+  Max: 20

.rubocop_todo.yml

@@ -0,0 +1,62 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-04-08 20:50:49 -0300 using RuboCop version 0.48.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 16
+
+# Offense count: 15
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 250
+
+# Offense count: 2
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Style/FileName:
+  Exclude:
+    - 'Dangerfile'
+    - 'fastlane/Deliverfile'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: when_needed, always, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Dangerfile'
+    - 'Gemfile'
+    - 'fastlane/Deliverfile'
+    - 'fastlane/Fastfile'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: only_raise, only_fail, semantic
+Style/SignalException:
+  Exclude:
+    - 'Dangerfile'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'Dangerfile'
+    - 'fastlane/Deliverfile'
+    - 'fastlane/Fastfile'

Dangerfile

@@ -1,12 +1,8 @@
 
 def warning_important_file_changed(file)
-  warn "Do you really want to modify #{file}?" if git.modified_files.include?(file)
+  warn "Modified #{file}?" if git.modified_files.include?(file)
 end
 
-# Sometimes it's a README fix, or something like that - which isn't relevant for
-# including in a project's CHANGELOG for example
-declared_trivial = github.pr_title.include? '#trivial'
-
 # Make it more obvious that a PR is a work in progress and shouldn't be merged yet
 warn 'PR is classed as Work in Progress' if (github.pr_title + github.pr_body).include? "[WIP]"
 
@@ -26,13 +22,15 @@ if github.pr_body.length < 5
   fail 'Please provide a summary in the Pull Request description'
 end
 
-
-# Change it later
+# Xcode
 build_file = File.expand_path 'result.json'
 system "rake generate_xcode_summary[#{build_file}]"
-json = xcode_summary.report build_file
+xcode_summary.report build_file
 
 slather.configure('swift-evolution.xcodeproj', 'swift-evolution')
 slather.notify_if_coverage_is_less_than(minimum_coverage: 80, notify_level: :warning)
 slather.notify_if_modified_file_is_less_than(minimum_coverage: 50, notify_level: :warning)
 slather.show_modified_files_coverage
+
+# RuboCop
+rubocop.lint

Gemfile

@@ -6,5 +6,6 @@ source 'https://rubygems.org'
 
 gem 'fastlane'
 gem 'rake', '12.0.0'
+gem 'rubocop', '0.48.1'
 gem 'xcpretty-json-formatter', '0.1.0'
-gem 'xcpretty-travis-formatter', '0.0.4'
+gem 'xcpretty-travis-formatter', '0.0.4'

Gemfile.lock

@@ -9,6 +9,7 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.5.1)
       public_suffix (~> 2.0, >= 2.0.2)
+    ast (2.3.0)
     babosa (1.0.2)
     claide (1.0.1)
     colored (1.2)
@@ -100,13 +101,24 @@ GEM
     multipart-post (2.0.0)
     nanaimo (0.2.3)
     os (0.9.6)
+    parser (2.4.0.0)
+      ast (~> 2.2)
     plist (3.2.0)
+    powerpack (0.1.1)
     public_suffix (2.0.5)
+    rainbow (2.2.1)
     rake (12.0.0)
     representable (2.3.0)
       uber (~> 0.0.7)
     retriable (2.1.0)
     rouge (1.11.1)
+    rubocop (0.48.1)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
     rubyzip (1.2.1)
     security (0.1.3)
     signet (0.7.3)
@@ -146,6 +158,7 @@ PLATFORMS
 DEPENDENCIES
   fastlane
   rake (= 12.0.0)
+  rubocop (= 0.48.1)
   xcpretty-json-formatter (= 0.1.0)
   xcpretty-travis-formatter (= 0.0.4)
 

fastlane/Deliverfile

@@ -2,7 +2,6 @@
 # If you want to have even more control, check out the documentation
 # https://github.com/fastlane/fastlane/blob/master/deliver/Deliverfile.md
 
-
 ###################### Automatically generated ######################
 # Feel free to remove the following line if you use fastlane (which you should)
 

fastlane/Fastfile

@@ -18,8 +18,6 @@ default_platform :ios
 platform :ios do
   before_all do
     # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
-    
-    
   end
 
   desc "Runs all the tests"
@@ -65,7 +63,6 @@ platform :ios do
   end
 end
 
-
 # More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
 # All available actions: https://docs.fastlane.tools/actions
 

rakelib/build-test.rake

@@ -104,11 +104,11 @@ def xcode(scheme: '',
   other_options = 'CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= PROVISIONING_PROFILE=' unless actions.include? 'archive'
   archive_options = archive_path.to_s.strip.empty? ? '-enableCodeCoverage YES' : "-archivePath '#{archive_path}'"
 
-  if WORKSPACE_PATH.nil?
-    project = "-project #{PROJECT_PATH}"
-  else
-    project = "-workspace '#{WORKSPACE_PATH}'"
-  end
+  project = if WORKSPACE_PATH.nil?
+              "-project #{PROJECT_PATH}"
+            else
+              "-workspace '#{WORKSPACE_PATH}'"
+            end
 
   sh "rm -f '#{xcode_log_file}' '#{report_file}'"
   sh "set -o pipefail && xcodebuild #{other_options} #{xcode_configuration} -destination '#{destination}' #{project} -scheme '#{scheme}' #{archive_options} #{actions} | tee '#{xcode_log_file}' | xcpretty --color --no-utf -r junit -o '#{report_file}'"

rakelib/setup-project.rake

@@ -25,18 +25,18 @@ end
 CARTHAGE_OPTIONS = '--platform iOS --no-use-binaries'
 
 desc 'Install dependencies in Carthage'
-task :carthage_install, [ :dependency ] do |_t, args|
+task :carthage_install, [:dependency] do |_t, args|
   dependency = args[:dependency]
   sh "carthage bootstrap #{CARTHAGE_OPTIONS} #{dependency}"
 end
 
-task :carthage_update, [ :dependency ] do |_t, args|
+task :carthage_update, [:dependency] do |_t, args|
   dependency = args[:dependency]
   sh "carthage update #{CARTHAGE_OPTIONS} #{dependency}"
 end
 
-task :carthage_clean, [ :dependency ] do |_t, args|
-  has_dependency = args[:dependency].to_s.strip.length != 0
+task :carthage_clean, [:dependency] do |_t, args|
+  has_dependency = !args[:dependency].to_s.strip.empty?
   sh 'rm -rf "~/Library/Caches/org.carthage.CarthageKit/"' unless has_dependency
   sh "rm -rf '#{BASE_PATH}/Carthage/'" unless has_dependency
 end
@@ -47,7 +47,7 @@ def brew_update
   sh 'brew update || brew update'
 end
 
-def brew_install( formula )
-  fail 'no formula' if formula.to_s.strip.length == 0
+def brew_install(formula)
+  raise 'no formula' if formula.to_s.strip.empty?
   sh " ( brew list #{formula} ) && ( brew outdated #{formula} || brew upgrade #{formula} ) || ( brew install #{formula} ) "
 end