lightningd: don't reject attempts to forward 2^32 msat out of hand.

rustyrussell · rustyrussell · commit 2770bcb158cf · 2021-08-30T15:56:20.000+09:30
The outgoing channeld still does that, for now, but that will change.

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
diff --git a/lightningd/peer_htlcs.c b/lightningd/peer_htlcs.c
@@ -735,14 +735,6 @@ static void forward_htlc(struct htlc_in *hin,
 		goto fail;
 	}
 
-	if (amount_msat_greater(amt_to_forward,
-				chainparams->max_payment)) {
-		/* ENOWUMBO! */
-		needs_update_appended = false;
-		failmsg = towire_required_channel_feature_missing(tmpctx);
-		goto fail;
-	}
-
 	/* BOLT #2:
 	 *
 	 * An offering node:

Original file line number	Diff line number	Diff line change
`@@ -735,14 +735,6 @@ static void forward_htlc(struct htlc_in *hin,`
`735`	`735`	`goto fail;`
`736`	`736`	`}`
`737`	`737`
`738`		`- if (amount_msat_greater(amt_to_forward,`
`739`		`- chainparams->max_payment)) {`
`740`		`- /* ENOWUMBO! */`
`741`		`- needs_update_appended = false;`
`742`		`- failmsg = towire_required_channel_feature_missing(tmpctx);`
`743`		`- goto fail;`
`744`		`- }`
`745`		`-`
`746`	`738`	`/* BOLT #2:`
`747`	`739`	`*`
`748`	`740`	`* An offering node:`