Skip to content

dualopen: Refactor dualopen to use interactivetx library #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddustin opened this issue Sep 20, 2022 · 0 comments
Open

dualopen: Refactor dualopen to use interactivetx library #5616

ddustin opened this issue Sep 20, 2022 · 0 comments
Assignees

Comments

@ddustin
Copy link
Collaborator

ddustin commented Sep 20, 2022

Update dualopen to use interactivetx module for interactive transaction building.

The interactive transaction building routines are being refactored out of dualopen to be used as a general module in three phases:

  1. Code pulled into module & interface made. See Collaborative transaction building #5287
  2. Channeld uses module to implement splicing
  3. Dualopen is updated to use the new module

This issue is for the third phase. Go through openingd/dualopend.c and remove all code that uses the TX_ADD_INPUT/TX_ADD_OUTPUT/TX_REMOVE_INPUT/TX_REMOVE_OUTPUT/TX_COMPLETE and related peer messages and replace them with code using the interface found in common/interactivetx.h

The thinking for this is two fold: dualopen is leaving experimental while splice is entering experimental. Dogfooding the new code in an experimental feature first seems prudent.

Secondly, it will allow an interop test between splicing using the new module and dualopen using the old method. This will give us greater assurances the refactor isn't introducing any unexpected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants